ipvlan support kube-proxy's ipvs mode #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR vishvananda/netlink#499 has been merged, update vendor to point new commit. Signed-off-by: Zhiyuan Hou <[email protected]>
When redirecting a skb with valid route to ingress, l3 stack may drop it. This patch uses tunnel_key to unset route before redirection. Signed-off-by: Zhiyuan Hou <[email protected]>
|
@zhiyuan0x The CI failed. Pls update the |
Yes, I am fixing it. |
zhiyuan0x
force-pushed
the
feature/support-ipvs
branch
from
aa90d25
to
7376277
Compare
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
- Coverage 6.08% 6.08% -0.01%
=========================================
Files 31 31
Lines 3977 3980 +3
=========================================
Hits 242 242
- Misses 3720 3723 +3
Partials 15 15
Continue to review full report at Codecov.
|
|
LGTM, Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ipvlan, skb redirected to host namespace is still with an old route info. If kube-proxy works on ipvs mode, these skb may be dropped by kernel route system. This PR use tunnel_key action to clear the route info and makes it work.