Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tag filter #721

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Nov 13, 2024

No description provided.

Signed-off-by: l1b0k <[email protected]>
@l1b0k l1b0k requested a review from BSWANG November 13, 2024 14:18
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.81%. Comparing base (00abe40) to head (8f7c2af).
Report is 4 commits behind head on release-1.8.

Files with missing lines Patch % Lines
pkg/factory/aliyun/aliyun.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.8     #721       +/-   ##
================================================
- Coverage        23.19%   12.81%   -10.39%     
================================================
  Files               62      148       +86     
  Lines             6574    16898    +10324     
================================================
+ Hits              1525     2165      +640     
- Misses            4806    14416     +9610     
- Partials           243      317       +74     
Flag Coverage Δ
unittests 12.81% <50.00%> (-10.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jzwlqx jzwlqx merged commit 144428d into AliyunContainerService:release-1.8 Nov 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants