Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance ipam #707

Merged
merged 3 commits into from
Oct 24, 2024
Merged

enhance ipam #707

merged 3 commits into from
Oct 24, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Oct 22, 2024

No description provided.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 28.48485% with 236 lines in your changes missing coverage. Please review.

Project coverage is 21.38%. Comparing base (b408c2f) to head (5d4befe).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/eni/crdv2.go 28.44% 153 Missing and 3 partials ⚠️
daemon/daemon.go 0.00% 53 Missing ⚠️
pkg/controller/multi-ip/node/pool.go 53.84% 10 Missing and 2 partials ⚠️
cmd/terway/main.go 0.00% 6 Missing ⚠️
cmd/terway-controlplane/terway-controlplane.go 0.00% 5 Missing ⚠️
plugin/driver/utils/utils.go 0.00% 3 Missing ⚠️
pkg/controller/node/node.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   19.80%   21.38%   +1.58%     
==========================================
  Files         123      119       -4     
  Lines       16863    15542    -1321     
==========================================
- Hits         3340     3324      -16     
+ Misses      13145    11842    -1303     
+ Partials      378      376       -2     
Flag Coverage Δ
unittests 21.38% <28.48%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the feat/cni branch 2 times, most recently from 4e8202d to ed465f8 Compare October 23, 2024 01:38
pkg/controller/multi-ip/node/pool_test.go Outdated Show resolved Hide resolved
daemon/daemon.go Show resolved Hide resolved
pkg/eni/crdv2.go Outdated Show resolved Hide resolved
pkg/eni/crdv2.go Outdated Show resolved Hide resolved
daemon/daemon.go Outdated Show resolved Hide resolved
pkg/controller/multi-ip/node/pool.go Outdated Show resolved Hide resolved
ipam: will wait until node has confirmed cni del is called
cni: will report cni del

Signed-off-by: l1b0k <[email protected]>
Signed-off-by: l1b0k <[email protected]>
@BSWANG BSWANG merged commit cef1874 into AliyunContainerService:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants