Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport the error handle #673

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 29, 2024

No description provided.

@l1b0k l1b0k merged commit a33d624 into AliyunContainerService:release-1.8 Aug 29, 2024
4 checks passed
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.18%. Comparing base (23c49fe) to head (bc32481).
Report is 5 commits behind head on release-1.8.

Files with missing lines Patch % Lines
pkg/aliyun/client/ecs.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8     #673      +/-   ##
===============================================
+ Coverage        23.13%   23.18%   +0.05%     
===============================================
  Files               62       62              
  Lines             6545     6548       +3     
===============================================
+ Hits              1514     1518       +4     
+ Misses            4788     4787       -1     
  Partials           243      243              
Flag Coverage Δ
unittests 23.18% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant