Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ipam2 #660

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Feat/ipam2 #660

merged 3 commits into from
Aug 5, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 1, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG August 1, 2024 06:59
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 27.72277% with 73 lines in your changes missing coverage. Please review.

Project coverage is 27.00%. Comparing base (4d90d2c) to head (1c0be1c).

Files Patch % Lines
pkg/eni/node_reconcile.go 0.00% 28 Missing ⚠️
pkg/controller/preheating/dummy.go 8.33% 22 Missing ⚠️
cmd/terway-controlplane/terway-controlplane.go 67.64% 11 Missing ⚠️
pkg/controller/multi-ip/node/pool.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controller/node/node.go 0.00% 2 Missing and 1 partial ⚠️
pkg/eni/crdv2.go 0.00% 3 Missing ⚠️
pkg/controller/pod-networking/networking.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   27.63%   27.00%   -0.63%     
==========================================
  Files          71       77       +6     
  Lines        7884     8334     +450     
==========================================
+ Hits         2179     2251      +72     
- Misses       5403     5765     +362     
- Partials      302      318      +16     
Flag Coverage Δ
unittests 27.00% <27.72%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the feat/ipam2 branch 2 times, most recently from fa5db88 to 41b4e0c Compare August 2, 2024 04:43
@BSWANG BSWANG merged commit 8d1e252 into AliyunContainerService:main Aug 5, 2024
8 of 9 checks passed
@l1b0k l1b0k deleted the feat/ipam2 branch August 8, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants