Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add singleflight for DescribeInstanceTypes #659

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jul 26, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG July 26, 2024 03:40
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.54%. Comparing base (94795f0) to head (89414ed).

Files Patch % Lines
pkg/aliyun/client/limit.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   27.60%   27.54%   -0.06%     
==========================================
  Files          71       71              
  Lines        7879     7884       +5     
==========================================
- Hits         2175     2172       -3     
- Misses       5402     5409       +7     
- Partials      302      303       +1     
Flag Coverage Δ
unittests 27.54% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 4d90d2c into AliyunContainerService:main Jul 26, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants