Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force disable tls in hubble args #331

Merged
merged 1 commit into from
Mar 15, 2022
Merged

add force disable tls in hubble args #331

merged 1 commit into from
Mar 15, 2022

Conversation

xh4n3
Copy link
Collaborator

@xh4n3 xh4n3 commented Mar 15, 2022

Cilium Hubble failed to start because it can not find a valid tls cert to expose hubble. This pr adds a force disable flag for hubble.

@xh4n3 xh4n3 requested a review from l1b0k March 15, 2022 11:30
@codecov-commenter
Copy link

Codecov Report

Merging #331 (e059c03) into main (7d708b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #331   +/-   ##
=====================================
  Coverage   4.45%   4.45%           
=====================================
  Files        120     120           
  Lines      10736   10736           
=====================================
  Hits         478     478           
  Misses     10223   10223           
  Partials      35      35           
Flag Coverage Δ
unittests 4.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d708b0...e059c03. Read the comment docs.

@xh4n3 xh4n3 changed the title [WIP] add force disable tls in hubble args add force disable tls in hubble args Mar 15, 2022
@xh4n3
Copy link
Collaborator Author

xh4n3 commented Mar 15, 2022

Local environment test passed

@l1b0k l1b0k merged commit 510374e into AliyunContainerService:main Mar 15, 2022
@xh4n3 xh4n3 deleted the bugfix/fix-cilium-hubble branch March 15, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants