CNI support create multi network #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
========================================
- Coverage 4.47% 4.10% -0.38%
========================================
Files 100 106 +6
Lines 9426 10283 +857
========================================
Hits 422 422
- Misses 8971 9827 +856
- Partials 33 34 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BSWANG
requested changes
Jan 5, 2022
| return err | ||
| } | ||
| veth1Cfg := generateVeth1Cfg(cfg, veth1, mac) | ||
| return nic.Setup(veth1, veth1Cfg) |
There was a problem hiding this comment.
对端网卡还没有UP的话是否会导致添加169.254.1.1网关的路由失败？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let CNI support create multi network