Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for host_stack_cidrs in IPVLAN mode #162

Merged
merged 2 commits into from
Dec 16, 2020
Merged

add support for host_stack_cidrs in IPVLAN mode #162

merged 2 commits into from
Dec 16, 2020

Conversation

xh4n3
Copy link
Collaborator

@xh4n3 xh4n3 commented Dec 15, 2020

Background:
The node-local-dns solution uses link-local address as DNS cache endpoint in cluster nodes.
In Terway's current IPVLAN mode, container traffic will be routed to ENIs on the host by default. If these traffic is not targeting serviceCIDRs or podCIDRs, traffic will be dropped.

Solution:
In order to support node-local-dns in IPVLAN mode, we need to redirect traffic targeting these link-local addresses to the host network stack and let interface nodelocaldns to respond.

I added host_stack_cidrs to the cni config, now user can configure these link-local addresses.

@codecov-io
Copy link

Codecov Report

Merging #162 (630c798) into master (2bbb3d1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #162      +/-   ##
=========================================
- Coverage    7.15%   7.14%   -0.02%     
=========================================
  Files          41      41              
  Lines        5419    5429      +10     
=========================================
  Hits          388     388              
- Misses       5008    5018      +10     
  Partials       23      23              
Impacted Files Coverage Δ
plugin/driver/drivers.go 0.00% <ø> (ø)
plugin/driver/ipvlan.go 0.62% <0.00%> (-0.01%) ⬇️
plugin/driver/raw_nic.go 0.00% <ø> (ø)
plugin/terway/cni.go 0.30% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbb3d1...630c798. Read the comment docs.

@BSWANG BSWANG merged commit 84b3eb7 into AliyunContainerService:master Dec 16, 2020
@BSWANG
Copy link
Member

BSWANG commented Dec 16, 2020

LGTM

@xh4n3 xh4n3 deleted the features/add-host-stack-cidrs branch December 16, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants