-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit-test for hasPort method #1654
test: add unit-test for hasPort method #1654
Conversation
We found this is your first time to contribute to Pouch, @forienlauo |
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 41.16% 41.14% -0.03%
==========================================
Files 274 274
Lines 18091 18091
==========================================
- Hits 7447 7443 -4
- Misses 9729 9734 +5
+ Partials 915 914 -1
|
7644590
to
be0748d
Compare
Signed-off-by: lauo <[email protected]>
Oh, actually this is pr which does the same thing as #1668. But this is much better I think. In addition this is done much earlier. What should we do? @HusterWan @fuweid |
LGTM |
Ⅰ. Describe what this PR did
#1641: add unit-test for hasPort method
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
NONE
Ⅳ. Describe how to verify it
NONE
Ⅴ. Special notes for reviews
NONE