Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for proxy/hasPort #1641

Closed
zhuangqh opened this issue Jul 5, 2018 · 0 comments
Closed

[help wanted] add unit-test for proxy/hasPort #1641

zhuangqh opened this issue Jul 5, 2018 · 0 comments
Labels
areas/test good first issue

Comments

@zhuangqh
Copy link
Contributor

zhuangqh commented Jul 5, 2018 •
edited
Loading

Ⅰ. Issue Description

Add unit-test for hasPort method which locate on ctrd/image_proxy_util.go.

You can take env_test.go for reference.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

please "Baiji" developer refer to this issue in your PR for the convenience for us to count your score.

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/test good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@frank-zsy @allencloud @zhuangqh @pouchrobot