-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo: fix misspells in code and comments #1429
Conversation
@idealhack Thanks for your contribution. 🍻 |
We found this is your first time to contribute to Pouch, @idealhack |
Thanks a lot for your work. Actually this is a vendor package and we have no plan to main the code of this part. I am afraid we cannot merge this. @idealhack |
I think here comes a flaky test, @fuweid :
|
@allencloud I see, but why there are different folders for vendor packages? |
@allencloud This is not flaky case. The pouchd cannot remove the running task. We are still investigating the issue. |
I'll keep this open for now. Feel free to close it when you open new ones for the ci and dependency issues. |
Could you help to vendor the latest libnetwork package with govendor tool? @idealhack |
Since #1344 is open, let's resolve the dependency issue in that thread. Feel free to close this one when you open a new one for the ci issue. |
Thanks @idealhack |
Ⅰ. Describe what this PR did
fix misspells in code and comments
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews