Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: fix misspells in code and comments #1429

Closed
wants to merge 1 commit into from

Conversation

idealhack
Copy link
Contributor

Ⅰ. Describe what this PR did

fix misspells in code and comments

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@idealhack Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @idealhack
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented May 29, 2018

CLA assistant check
All committers have signed the CLA.

@allencloud
Copy link
Collaborator

allencloud commented May 29, 2018

Thanks a lot for your work. Actually this is a vendor package and we have no plan to main the code of this part. I am afraid we cannot merge this. @idealhack
And much other work are appreciated. 😄 🍻

@allencloud
Copy link
Collaborator

I think here comes a flaky test, @fuweid :

FAIL: /go/src/github.com/alibaba/pouch/test/api_container_logs_test.go:52: APIContainerLogsSuite.TestNoShowStdoutAndShowStderr
/go/src/github.com/alibaba/pouch/test/api_container_logs_test.go:60:
    ...
/go/src/github.com/alibaba/pouch/test/util_api.go:25:
    c.Assert(resp.StatusCode, check.Equals, status, check.Commentf("Error:%s", got.Message))
... obtained int = 500
... expected int = 204
... Error:failed to destroy container: 56f4ce44a1f97168a7f756122c7f31daa6707809da80a2ebc8dd306631dd77fd: failed to delete container: cannot delete running task 56f4ce44a1f97168a7f756122c7f31daa6707809da80a2ebc8dd306631dd77fd: failed precondition

@idealhack
Copy link
Contributor Author

@allencloud I see, but why there are different folders for vendor packages?

@allencloud
Copy link
Collaborator

I see, but why there are different folders for vendor packages?

This is a good question. Lots of things have been discussed before, like:
#1344
#428
#750

I think we do need to take into vendor the latest version into consideration. WDYT? @rudyfly

@fuweid
Copy link
Contributor

fuweid commented May 29, 2018

@allencloud This is not flaky case. The pouchd cannot remove the running task. We are still investigating the issue.

@idealhack
Copy link
Contributor Author

I'll keep this open for now. Feel free to close it when you open new ones for the ci and dependency issues.

@allencloud
Copy link
Collaborator

Could you help to vendor the latest libnetwork package with govendor tool? @idealhack
I think this is what we wish to finish. We encourage you to finish it very much and feel free to tell us if you have any problem when doing this.

@idealhack
Copy link
Contributor Author

idealhack commented May 30, 2018

Since #1344 is open, let's resolve the dependency issue in that thread.

Feel free to close this one when you open a new one for the ci issue.

@allencloud
Copy link
Collaborator

Thanks @idealhack
While I do not think this issue could help. And I am closing it.

@allencloud allencloud closed this May 31, 2018
@idealhack idealhack deleted the typo branch June 1, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants