Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] do we have a plan to revendor libnetwork to the latest version or stable one #1344

Closed
allencloud opened this issue May 17, 2018 · 4 comments · Fixed by #1445
Closed
Assignees
Labels
areas/network kind/question all questions or confusion about this project

Comments

@allencloud
Copy link
Collaborator

Ⅰ. Issue Description

We have vendor libnetwork to take advantages of libnetwork's ability on network management. While I am afraid that currently we met several serious issues ever which are not so easy to handle, so we did some tricky work to handle this:

I think we should take more things into consideration whether to use latest or stable version of libnetwork to bring more convenience.

ping @rudyfly

@idealhack
Copy link
Contributor

I found this is not easy with govendor. Have you considered migrating to dep?

@fuweid
Copy link
Contributor

fuweid commented May 31, 2018

Hi @idealhack,could you mind to explain the special thing in dep? Thanks

@idealhack
Copy link
Contributor

@fuweid dep is a better package manager in general and it is maintain by Go team.

@idealhack
Copy link
Contributor

idealhack commented May 31, 2018

In fact, I encountered some problems with pouch and govendor, for example:

  1. Some packages are dependencies of pouch not in vendor.json.

  2. Some packages are not direct dependencies of pouch currently in vendor.json.

  3. Why does so many different packages using a same revision 2b8ed96d2a422bf205adcdfa05272dc12c81613b? This is a commit hash in containerd.

In the meantime, dep is good at resolving dependencies and migrating from other tools, but it seems pouch want to depend on two versions of cri runtime, this can not be done by dep itself, by design. so I asked about this in #1359.

Anyway, despite of these problems, I managed get libnetwork with govendor working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/network kind/question all questions or confusion about this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants