feature: add timeout handler for execSync in cri part #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZouRui89
force-pushed
the
cri
branch
4 times, most recently
from
c3a519d to
a601b8f
Compare
Signed-off-by: Zou Rui <[email protected]>
|
I closed the old one because a recently merged refactor pr caused many conflicts. |
|
LGTM @YaoZengzeng Please take a look. If you don't have any question, I will merge this PR. |
|
LGTM Thanks for your excellent job @ZouRui89 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui [email protected]
Ⅰ. Describe what this PR did
This pr adds timeout handler for execSync in cri part.
I/O pipe mechanism is used to enhance the degree of simplicity, based on which the data type of memBuffer is changed to allow I/O operations.
Thus, instead of checking if the execution is finished every 100 millisecond, the error io.copy returns is used to control the data flow.
Ⅱ. Does this pull request fix one issue?
fixes #1274
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews