Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add timeout in ExecSync for CRI #1274

Closed
fuweid opened this issue May 7, 2018 · 0 comments · Fixed by #1318
Closed

[feature request] add timeout in ExecSync for CRI #1274

fuweid opened this issue May 7, 2018 · 0 comments · Fixed by #1318
Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer

Comments

@fuweid
Copy link
Contributor

fuweid commented May 7, 2018

Ⅰ. Issue Description

For now, the ExecSync doesn't have timeout functionality. If we don't have this, the long-time exec will consume the pouchd resource, for example, top/sleep command.

Besides this, the ExecSync uses the spinning check the status of command. It is not ideally and we should use pipe IO to copy and block it. If it is timeout or finish, we will know. Spinning-check isn't good to pouchd.

Ⅱ. Describe what happened

The long-running process will take pouchd down.

Ⅲ. Describe what you expected to happen

ExecSync has the timeout limitation.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

@YaoZengzeng

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer
Projects
None yet
2 participants