More equivalency declarations #10694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggested change following a conversation also with @aalkin These equivalency declarations have an important role for avoiding that track pre-selection and MC pre-selection depend unnecessarily on the track propagation workflow and on the data being analysed being from Run 2 or Run 3. By declaring TracksExtra and McTrackLabels to be equivalent to the base Track tables, one can de-reference an index to the base Track tables straight to the TracksExtra or McTrackLabels tables. As an example use case, this will greatly simplify the V0 and cascade candidate pre-selectors as these can loop over the TracksExtra properties belonging to the Tracks that are indexed in the array pairs or triplets without ever resolving the main Track table, which is only needed when using the actual track parameters. Without this equivalency, the existing four process functions would have to be duplicated into 8 process functions.
|
Hm, these errors seem totally unrelated to the change done in the PR... Not sure if they are worrisome or not. Maybe (when convenient, not necessarily during the weekend!) @ktf @TimoWilken could you comment? Thanks a lot!! |
|
Not sure if someone did something, but I guess so: the errors disappeared :-) - thanks a lot!! |
jgrosseo
approved these changes
Feb 6, 2023
This was referenced Feb 7, 2023
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested change following a conversation with @aalkin (thanks a lot!)
These equivalency declarations have an important role in avoiding that track pre-selections and MC pre-selections depend unnecessarily on the track propagation workflow (or on the data being from Run 2 or Run 3). By declaring
TracksExtraandMcTrackLabelsto be equivalent to the baseTracks/TracksIUtables for indexing purposes, one can de-reference an index to the base track tables straight to theTracksExtraorMcTrackLabelstables without going through theTracksorTracksIUtables and populate other tables that can still be joined with the baseTracks/TracksIUtables later on and filtered out as necessary.As an example use case, this will greatly simplify the V0 and cascade candidate pre-selectors, effectively keeping the number of
processfunctions down to only four (instead of 8 or more to account for various combinations ofTracks/TracksIU). This has already been tested to work very well locally.