Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS3: Base: Make ALPIDE pixel size configurable #10690

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

f3sch
Copy link
Collaborator

@f3sch f3sch commented Feb 3, 2023

In preparation for evaluating digits and different pixel sizes.

Signed-off-by: Felix Schlepper [email protected]

@f3sch f3sch requested review from fgrosa and arossi81 as code owners February 3, 2023 16:40
mconcas
mconcas previously approved these changes Feb 4, 2023
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3sch the code looks good, thanks a lot! I would just ask you to rename "Alpide" to "SuperAlpide" to be cosistent with the SegmentationSuperAlpide (this will not be the final name of the ITS3 chip, but still).

v1->v2: Changed Name from Alpide to SuperAlpide to be more consistent

Signed-off-by: Felix Schlepper <[email protected]>
@mconcas mconcas merged commit 06af269 into AliceO2Group:dev Feb 7, 2023
@f3sch f3sch deleted the its3_segAlpideConf branch February 7, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants