-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITS-SV: fix aggressive rounding in determinant #10668
Conversation
@shahor02, long story short: the bug was on my side, we couldn't see it before last change to seeding vertexer because these clusters of lines were naturally discarded. |
@chiarazampolli, this is indeed a fix we want asap, especially before apass3. |
@mconcas thanks, will merge as soon as the CIs are passed |
Error while checking build/O2/fullCI for 3c0f9fd at 2023-02-02 13:28:
Full log here. |
@shahor02 this is now green, could you just approve it? I would like to see whether I still have permissions to merge PRs on where I am codeowner. Since it looks like I have issues in another pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mconcas done
@TimoWilken It looks like I lost the permission to merge PR where I am codeowner of all files. |
nevermind, I have same issue here. But I'll fix this in another spot. This can be merged, thanks. |
No description provided.