Create DCAFitter under ./Common #10644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please consider the following formatting changes to AliceO2Group#10644
|
Marked ready so all tests can proceed over the weekend. Please do not merge! |
shahor02
approved these changes
Jan 28, 2023
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT PR] This is a deliberate and temporary duplicate of the
DCAfittercontained inDetectorsVertexing, done by @shahor02. The duplication will allow for a subsequent O2Physics change such that any analysis task linking to DetectorsVertexing can instead link to aDCAFitterlibrary and then theDCAFittercan be entirely removed from DetectorsVertexing, with DetectorsVertexing then depending on theDCAFittermodule underCommon/DCAFitter. This change should improve memory consumption during analysis becauseDetectorsVertexinglinks toGlobalTracking, which links to several libraries that are not at all required for analysis but are still being unnecessarily loaded.Tagging people that might want to be informed for completeness: @njacazio @ercolessi @ktf @aalkin @jgrosseo @mpuccio @strogolo @fgrosa