-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discard TRD tracks with bad quality #10540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martenole
but why not use existing GPUSettingsRecTRD ? In the end, the new params are in the same spirit as mTracker->Param().rec.trd.chi2StrictCut
True, I think I made it too complicated. I thought that this is not strictly a GPU setting, but still it belongs to the TRD reconstruction of course. So I will move it to the GPUSettingsList |
Error while checking build/O2/fullCI for 711d36d at 2023-01-11 14:57:
Full log here. |
The minimum number of TRD tracklets per track is configurable and set to 3. This avoids that e.g. ITS-TPC tracks are matched to a single tracklet (which is rather likely to be fake) and then don't have a chance anymore to be matched to TOF.
Also the minimum track quality can be specified, but before restricting this I would like to do some more tests. Therefore max chi2 value is set here to a very high value.
This also implies that downstream we will not have any TRD tracks with less than
nTracketsMin
tracklets, e.g. for vDrift calibration. But I think we are not using tracks with <= 2 tracklets in any case there so it should be no problem.