Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ITS3, ITS] Modify the description of carbon foam #10520

Merged
merged 7 commits into from
Jan 18, 2023
Merged

[ITS3, ITS] Modify the description of carbon foam #10520

merged 7 commits into from
Jan 18, 2023

Conversation

ChunzhengLab
Copy link
Contributor

@ChunzhengLab ChunzhengLab commented Jan 2, 2023 •
edited
Loading

  • The glue on one side of foam is modified to glue on both sides;
  • The geometric parameters of carbon foam are revised according to the drawing.

@ChunzhengLab
Copy link
Contributor Author

@fgrosa

@fgrosa
Copy link
Collaborator

fgrosa commented Jan 13, 2023

@shahor02 can this PR be merged? It is open since more than one week and the error seems unrelated. Thanks!

@mconcas mconcas merged commit 961e594 into AliceO2Group:dev Jan 18, 2023
fgrosa pushed a commit to fgrosa/AliceO2 that referenced this pull request Jan 20, 2023
@ChunzhengLab @fgrosa
[ITS3, ITS] Modify the description of carbon foam (AliceO2Group#10520)
ef6a368 
* [ITS, ITS3] Implement Dead Zones and Carbon Foam for ITS3 Inner Barrel

* [ITS, ITS3] Implement Dead Zones and Carbon Foam for ITS3 Inner Barrel

* [ITS3, ITS] Modify the description of carbon foam
This was referenced Feb 16, 2023
Closed
Closed
Elros60 pushed a commit to Elros60/AliceO2 that referenced this pull request Feb 24, 2023
@ChunzhengLab @Elros60
[ITS3, ITS] Modify the description of carbon foam (AliceO2Group#10520)
a439ddb 
* [ITS, ITS3] Implement Dead Zones and Carbon Foam for ITS3 Inner Barrel

* [ITS, ITS3] Implement Dead Zones and Carbon Foam for ITS3 Inner Barrel

* [ITS3, ITS] Modify the description of carbon foam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgrosa fgrosa fgrosa approved these changes

@mconcas mconcas mconcas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChunzhengLab @fgrosa @mconcas