Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Oceananigans #201

Merged
merged 12 commits into from
Feb 28, 2024
Merged

Revisit Oceananigans #201

merged 12 commits into from
Feb 28, 2024

Conversation

lukem12345
Copy link
Member

@lukem12345 lukem12345 commented Feb 12, 2024

Revisit the Oceananigans.jl NonhydrostaticModel implementation.

@lukem12345 lukem12345 changed the title Revisit NHS momentum eqn and add turbulence closure Revisit Oceananigans Feb 12, 2024
@lukem12345 lukem12345 self-assigned this Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (eb71775) to head (ef97e96).
Report is 1 commits behind head on main.

❗ Current head ef97e96 differs from pull request most recent head 7a721cc. Consider uploading reports for the commit 7a721cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   78.39%   78.39%           
=======================================
  Files           4        4           
  Lines         523      523           
=======================================
  Hits          410      410           
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukem12345
Copy link
Member Author

Cool new DEC operators are included in v0.6.2 of CombinatorialSpaces, and v0.1.3 of DiagrammaticEquations has a couple more type inference rules. This PR adds a docs page for the Oceananigans demo, and is ready to merge when the docs build builds.

speed_torus

@lukem12345 lukem12345 marked this pull request as ready for review February 27, 2024 22:57
@lukem12345 lukem12345 merged commit 690f88b into main Feb 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants