-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create In-Place Variants for new Wedges #208
Comments
Good catch, George. Could you make a quick set of instructions for how to add such support? |
That should be it but it's been a while since I've done this and I remember the solution to getting the wedge to work was kinda hacky. Lmk if anything goes awry. |
We will hold off on this feature since it would be best to introduce the in-place version of these operators at the same time we add GPU support for these operators. GPU kernels are always in-place. |
This issue can be addressed by the current push in CombinatorialSpaces towards kernelizing operators AlgebraicJulia/CombinatorialSpaces.jl#113 In-place operators and their GPU versions are now one-and-the-same. |
PR #201 introduced new wedge operators for various dual cases but as of now these are all out-of-place operators. Mirroring the pp wedges structure, we should include wrappers to provide an in-place and an out-of-place version for dec_matrix_generate and update gensim to unlock this functionality for simulation generation.
The text was updated successfully, but these errors were encountered: