[ACS-8489] Legal Holds keyboard accessibility #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-jaskowski
requested review from
DenysVuika,
tomson7777,
MichalKinas,
AleksanderSklorz,
tamaragruszka and
DaryaBalvanovich
tamaragruszka
approved these changes
Aug 7, 2024
| ); | ||
| component.ngOnInit(); | ||
| fixture.detectChanges(); | ||
| badges = fixture.debugElement.queryAll(By.css('.adf-datatable-cell-badge')).map((badge) => badge.nativeElement); |
There was a problem hiding this comment.
maybe use harness here too?
There was a problem hiding this comment.
With harness we can only test mat-icon name, tooltip is a property of adf-icon, that can't be tested with harness
| let runActionSpy: jasmine.Spy; | ||
| beforeEach(() => { | ||
| spyOn(appExtensionService, 'getBadges').and.returnValue( | ||
| of([{ id: 'test', type: ContentActionType.custom, icon: 'warning', tooltip: 'test tooltip', actions: { click: 'test' } }]) |
There was a problem hiding this comment.
I would be into define the object in one place, instead three separate almost the same
There was a problem hiding this comment.
Nice catch, fixed, thanks!
...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts
Outdated
Show resolved
Hide resolved
...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts
Outdated
Show resolved
Hide resolved
...lib/components/dl-custom-components/datatable-cell-badges/datatable-cell-badges.component.ts
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Aug 8, 2024
...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html
Show resolved
Hide resolved
|
SonarCloud started reporting the |
...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts
Outdated
Show resolved
Hide resolved
swapnil-verma-gl
approved these changes
Aug 9, 2024
DaryaBalvanovich
approved these changes
Aug 9, 2024
MichalKinas
approved these changes
Aug 9, 2024
| @@ -34,6 +34,12 @@ import { IconComponent, TranslationService } from '@alfresco/adf-core'; | |||
| import { FormControl, ReactiveFormsModule } from '@angular/forms'; | |||
| import { switchMap, takeUntil } from 'rxjs/operators'; | |||
| import { AppExtensionService } from '@alfresco/aca-shared'; | |||
| import { MatOptionSelectionChange } from '@angular/material/core'; | |||
|
|
|||
| export interface ActionsDropdownSelectionEvent { | |||
There was a problem hiding this comment.
Suggested change
| export interface ActionsDropdownSelectionEvent { | |
| export interface BulkActionsDropdownSelectionEvent { |
|
DaryaBalvanovich
added a commit
that referenced
this pull request
Aug 14, 2024
…ialog with Manage Existing Holds/Apply New Hold tabs (#4019) * [ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown (#3956) * ACS-8036 create bulk-actions-dropdown * ACS-8325 update names and add unit tests * ACS-8325 added icon and unit tests * ACS-8325 fix translation * ACS-8325 add and refactor tests in app extension service * ACS-8325 resolve conversations: remove loadBulkActions, rename bulk schema, add translations * ACS-8325 update state * ACS-8325 temporary remove disabled state as it doesn't work after Angular migration * ACS-8325 add formControl and tests * ACS-8325 clean code * ACS-8325 place create component to one place * ACS-8325 add condition to use title if no description provided and cover with test * ACS-8325 add tooltip and update Badge interface * ACS-8325 rename class names and mockItem object * [ACS-8326] enable running actions from bulk dropdown and resetting selection (#3971) * ACS-8036 create bulk-actions-dropdown * ACS-8325 update names and add unit tests * ACS-8325 fix translation * ACS-8325 resolve conversations: remove loadBulkActions, rename bulk schema, add translations * ACS-8325 temporary remove disabled state as it doesn't work after Angular migration * ACS-8325 add formControl and tests * ACS-8325 add condition to use title if no description provided and cover with test * ACS-8325 add tooltip and update Badge interface * ACS-8326 enable running actions from bulk dropdown and resetting dropdown selection * ACS-8326 review remarks - use select control, fix naming * ACS-8326 fix unit test selectors * ACS-8326 review remarks - change property name to more universal, adjust unit tests --------- Co-authored-by: Darya Balvanovich <[email protected]> * [ACS-8424][Bulk Legal Hold] Add Badge for items (#3985) * [ACS-8424] display badges in search result * [ACS-8424] display badges in search result * ACS-8424 create separate badge component, add/move unit tests, undo highlight change failing tests * ACS-8424 template cleanup * ACS-8424 template cleanup cleanup * ACS-8424 revert single deletion in template * ACS-8424 rename new component, change property order --------- Co-authored-by: g-jaskowski <[email protected]> * ACS-8458 refactor styles (#4018) * [ACS-8489] Legal Holds keyboard accessibility (#4009) * ACS-8489 handle keyboard accessibility * ACS-8489 wording fix * ACS-8489 change function name * ACS-8489 fix typo * ACS-8489 review remarks - simplify keyboard event handling, improve unit tests * ACS-8489 move duplicated code to method * ACS-8489 change type name to more precise * [ACS-8036] fix icon visibility in mat-select * ACS-8036 fix styles and import * ACS-8036 remove async from test * ACS-8036 handle event when dropdown closed * ACS-8036 fix rebase issues * ACS-8036 fix rebase issues * ACS-8036 fix rebase --------- Co-authored-by: Grzegorz Jaśkowski <[email protected]> Co-authored-by: tamaragruszka <[email protected]> Co-authored-by: g-jaskowski <[email protected]> Co-authored-by: tamaragruszka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8489
What is the new behaviour?
Added keyboard accessibility in components reported by SonarCloud.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: