[ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown #3956

DaryaBalvanovich · 2024-07-18T12:19:09Z

Please check if the PR fulfills these requirements

https://hyland.atlassian.net/browse/ACS-8325

The commit message follows our guidelines

Tests for the changes have been added (for bug fixes / features)

Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

Bugfix

Feature

Code style update (formatting, local variables)

Refactoring (no functional changes, no api changes)

Build related changes

Documentation

Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
Add dropdown to the search bar

disable mode when no search results:

when there are search results:

Does this PR introduce a breaking change? (check one with "x")

Yes

No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

DaryaBalvanovich · 2024-07-18T12:21:56Z

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.scss

+.aca-bulk-select {
+  margin-top: 31px;
+}


will be removed after Angular migration

swapnil-verma-gl · 2024-07-19T04:39:01Z

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.scss

+  margin-top: 1.4375em;
+  width: 295px;
+
+  .mat-form-field-flex,


As part of the angular migration, we also added a mat-selectors file, that contains all angular material selectors. The plan is to use the references from that file, instead of directly referring to .mat selectors in our css (I assume that is what @DaryaBalvanovich meant when they said 'will be removed after Angular migration).

However, I am wondering how we will keep track of all the material selectors that were added/are being added after the angular migration was started (such as this one). Maybe we can add TODO statements, and then do a project wide search after the ng migration merge. Or we can keep references in a sepearate single file.
@MichalKinas @DenysVuika what do you think?

Sounds good, fortunately ADF should be merged today and ACA will be next so this PR will be merged after migration one

added TODO and created story for it that will be done in the end of Legal Hold development ACS-8458

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts

swapnil-verma-gl · 2024-07-19T04:52:29Z

projects/aca-content/src/lib/store/initial-state.ts

@@ -56,7 +56,8 @@ export const INITIAL_APP_STATE: AppState = {
    status: {
      isQuickShareEnabled: true
    }
-  } as any
+  } as any,
+  searchItemsTotalCount: null


Can you check if these changes still work on the latest develop, or need to be moved to a different file? I think this file was completely wiped recently, with just a single export statement as part of #3952 (changes here)

thank you for this catch!
I will try to update all our branches with the latest changes.
It's not easy to develop a feature without merging into development and keep it only in feature branches when there are so many important architecture changes in 3 repositories.
There are 3 developers who are working on the feature and we have a lot of nested branches.

projects/aca-shared/src/lib/services/app.extension.service.ts

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html

MichalKinas · 2024-07-19T06:44:06Z

extension.schema.json

@@ -854,6 +854,12 @@
          "items": { "$ref": "#/definitions/contentActionRef" },
          "minItems": 1
        },
+        "bulk-actions-dropdown": {


This should be a generic feature since we will add new bulk actions in the future so I would call it bulk-actions

these actions appears in dropdown only. But it's ok for me to rename

For now but this is supposed to be the generic feature for loading bulk actions, in future they might be used in other places too, please keep that in mind

renamed to bulk-actions and remove component property

extension.schema.json

MichalKinas · 2024-07-19T06:46:24Z

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.scss

+  margin-top: 1.4375em;
+  width: 295px;
+
+  .mat-form-field-flex,


Sounds good, fortunately ADF should be merged today and ACA will be next so this PR will be merged after migration one

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts

...ects/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.ts

projects/aca-shared/src/lib/services/app.extension.service.ts

…chema, add translations

…ular migration

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts

Approved by mistake

…ver with test

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html

MichalKinas · 2024-07-29T14:20:55Z

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html

+  <mat-select
+    [formControl]="disableControl"
+    [placeholder]="placeholder"
+    panelClass="aca-bulk-select"


Suggested change

panelClass="aca-bulk-select"

panelClass="aca-bulk-actions-select"

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html

MichalKinas · 2024-07-29T14:21:54Z

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html

+        *ngIf="option.icon"
+        [title]="option.title | translate"
+        [value]="option.icon"
+        [attr.data-automation-id]="'aca-option-icon-' + option.id"


Suggested change

[attr.data-automation-id]="'aca-option-icon-' + option.id"

[attr.data-automation-id]="'aca-bulk-action-icon-' + option.id"

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts

sonarqubecloud · 2024-07-29T19:47:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* ACS-8036 create bulk-actions-dropdown * ACS-8325 update names and add unit tests * ACS-8325 added icon and unit tests * ACS-8325 fix translation * ACS-8325 add and refactor tests in app extension service * ACS-8325 resolve conversations: remove loadBulkActions, rename bulk schema, add translations * ACS-8325 update state * ACS-8325 temporary remove disabled state as it doesn't work after Angular migration * ACS-8325 add formControl and tests * ACS-8325 clean code * ACS-8325 place create component to one place * ACS-8325 add condition to use title if no description provided and cover with test * ACS-8325 add tooltip and update Badge interface * ACS-8325 rename class names and mockItem object

…ialog with Manage Existing Holds/Apply New Hold tabs (#4019) * [ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown (#3956) * ACS-8036 create bulk-actions-dropdown * ACS-8325 update names and add unit tests * ACS-8325 added icon and unit tests * ACS-8325 fix translation * ACS-8325 add and refactor tests in app extension service * ACS-8325 resolve conversations: remove loadBulkActions, rename bulk schema, add translations * ACS-8325 update state * ACS-8325 temporary remove disabled state as it doesn't work after Angular migration * ACS-8325 add formControl and tests * ACS-8325 clean code * ACS-8325 place create component to one place * ACS-8325 add condition to use title if no description provided and cover with test * ACS-8325 add tooltip and update Badge interface * ACS-8325 rename class names and mockItem object * [ACS-8326] enable running actions from bulk dropdown and resetting selection (#3971) * ACS-8036 create bulk-actions-dropdown * ACS-8325 update names and add unit tests * ACS-8325 fix translation * ACS-8325 resolve conversations: remove loadBulkActions, rename bulk schema, add translations * ACS-8325 temporary remove disabled state as it doesn't work after Angular migration * ACS-8325 add formControl and tests * ACS-8325 add condition to use title if no description provided and cover with test * ACS-8325 add tooltip and update Badge interface * ACS-8326 enable running actions from bulk dropdown and resetting dropdown selection * ACS-8326 review remarks - use select control, fix naming * ACS-8326 fix unit test selectors * ACS-8326 review remarks - change property name to more universal, adjust unit tests --------- Co-authored-by: Darya Balvanovich <[email protected]> * [ACS-8424][Bulk Legal Hold] Add Badge for items (#3985) * [ACS-8424] display badges in search result * [ACS-8424] display badges in search result * ACS-8424 create separate badge component, add/move unit tests, undo highlight change failing tests * ACS-8424 template cleanup * ACS-8424 template cleanup cleanup * ACS-8424 revert single deletion in template * ACS-8424 rename new component, change property order --------- Co-authored-by: g-jaskowski <[email protected]> * ACS-8458 refactor styles (#4018) * [ACS-8489] Legal Holds keyboard accessibility (#4009) * ACS-8489 handle keyboard accessibility * ACS-8489 wording fix * ACS-8489 change function name * ACS-8489 fix typo * ACS-8489 review remarks - simplify keyboard event handling, improve unit tests * ACS-8489 move duplicated code to method * ACS-8489 change type name to more precise * [ACS-8036] fix icon visibility in mat-select * ACS-8036 fix styles and import * ACS-8036 remove async from test * ACS-8036 handle event when dropdown closed * ACS-8036 fix rebase issues * ACS-8036 fix rebase issues * ACS-8036 fix rebase --------- Co-authored-by: Grzegorz Jaśkowski <[email protected]> Co-authored-by: tamaragruszka <[email protected]> Co-authored-by: g-jaskowski <[email protected]> Co-authored-by: tamaragruszka <[email protected]>

DaryaBalvanovich changed the title ~~[ACS-8036] [Bulk Legal Hold] Create Bulk Actions Dropdown~~ [ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown Jul 18, 2024

DaryaBalvanovich requested review from MichalKinas and DenysVuika and removed request for MichalKinas July 18, 2024 12:19

DaryaBalvanovich assigned tomson7777, jacekpluta, AleksanderSklorz, g-jaskowski and tamaragruszka and unassigned tomson7777, jacekpluta, AleksanderSklorz, g-jaskowski and tamaragruszka Jul 18, 2024

DaryaBalvanovich requested review from MichalKinas, tomson7777, jacekpluta, AleksanderSklorz, g-jaskowski and tamaragruszka July 18, 2024 12:20

DaryaBalvanovich commented Jul 18, 2024

View reviewed changes

g-jaskowski approved these changes Jul 18, 2024

View reviewed changes

swapnil-verma-gl reviewed Jul 19, 2024

View reviewed changes

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts Outdated Show resolved Hide resolved

swapnil-verma-gl reviewed Jul 19, 2024

View reviewed changes

projects/aca-shared/src/lib/services/app.extension.service.ts Outdated Show resolved Hide resolved

swapnil-verma-gl reviewed Jul 19, 2024

View reviewed changes

...ts/aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.html Outdated Show resolved Hide resolved

MichalKinas requested changes Jul 19, 2024

View reviewed changes

DaryaBalvanovich added 2 commits July 23, 2024 22:35

ACS-8036 create bulk-actions-dropdown

2c4d930

ACS-8325 update names and add unit tests

fcf1835

DaryaBalvanovich added 7 commits July 23, 2024 22:35

ACS-8325 fix translation

9887136

ACS-8325 add and refactor tests in app extension service

084db92

ACS-8325 resolve conversations: remove loadBulkActions, rename bulk s…

6fb603d

…chema, add translations

ACS-8325 update state

359e04f

ACS-8325 temporary remove disabled state as it doesn't work after Ang…

55d576e

…ular migration

ACS-8325 add formControl and tests

33a63bd

ACS-8325 clean code

3898c21

DaryaBalvanovich force-pushed the ACS-8325-bulk-create-bulk-actions-dropdown branch from 7f6ab2c to 3898c21 Compare July 23, 2024 20:35

DaryaBalvanovich requested review from swapnil-verma-gl and MichalKinas July 23, 2024 20:37

swapnil-verma-gl reviewed Jul 24, 2024

View reviewed changes

...aca-content/src/lib/components/bulk-actions-dropdown/bulk-actions-dropdown.component.spec.ts Show resolved Hide resolved

swapnil-verma-gl previously approved these changes Jul 24, 2024

View reviewed changes

ACS-8325 place create component to one place

4e83271

swapnil-verma-gl approved these changes Jul 24, 2024

View reviewed changes

ACS-8325 add condition to use title if no description provided and co…

25408cb

…ver with test

DenysVuika added the Legal Holds label Jul 25, 2024

ACS-8325 add tooltip and update Badge interface

f9fa5c0

g-jaskowski approved these changes Jul 29, 2024

View reviewed changes

MichalKinas reviewed Jul 29, 2024

View reviewed changes

ACS-8325 rename class names and mockItem object

67249e9

DaryaBalvanovich requested a review from MichalKinas July 29, 2024 19:49

MichalKinas approved these changes Jul 30, 2024

View reviewed changes

DaryaBalvanovich merged commit 8e7a80b into ACS-8036-bulk-update Jul 30, 2024
2 checks passed

DaryaBalvanovich deleted the ACS-8325-bulk-create-bulk-actions-dropdown branch July 30, 2024 08:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown #3956

[ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown #3956

DaryaBalvanovich commented Jul 18, 2024

DaryaBalvanovich Jul 18, 2024

swapnil-verma-gl Jul 19, 2024 •

edited

Loading

MichalKinas Jul 19, 2024

DaryaBalvanovich Jul 23, 2024

swapnil-verma-gl Jul 19, 2024

DaryaBalvanovich Jul 19, 2024

MichalKinas Jul 19, 2024

DaryaBalvanovich Jul 19, 2024

MichalKinas Jul 19, 2024

DaryaBalvanovich Jul 23, 2024

MichalKinas Jul 19, 2024

MichalKinas Jul 29, 2024

DaryaBalvanovich Jul 29, 2024

MichalKinas Jul 29, 2024

DaryaBalvanovich Jul 29, 2024

sonarqubecloud bot commented Jul 29, 2024

	panelClass="aca-bulk-select"
	panelClass="aca-bulk-actions-select"

	[attr.data-automation-id]="'aca-option-icon-' + option.id"
	[attr.data-automation-id]="'aca-bulk-action-icon-' + option.id"

[ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown #3956

[ACS-8325] [Bulk Legal Hold] Create Bulk Actions Dropdown #3956

Conversation

DaryaBalvanovich commented Jul 18, 2024

Choose a reason for hiding this comment

swapnil-verma-gl Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 29, 2024

Quality Gate passed

swapnil-verma-gl Jul 19, 2024 •

edited

Loading