Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6620] Use extensions instead of content key for viewer extensions #3610

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/extending/application-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ All the customizations are stored in the `features` section of the configuration
"viewer": {
"toolbarActions:": [],
"openWith": [],
"content": []
"extensions": []
},
"sidebar": [],
"content-metadata-presets": []
Expand Down Expand Up @@ -397,7 +397,7 @@ declared in the `rules` section:

Viewer component in ACA supports the following extension points:

- Content Viewers
- Viewer extensions
- Toolbar actions
- `More` toolbar actions
- `Open With` actions
Expand All @@ -419,9 +419,9 @@ Viewer component in ACA supports the following extension points:
}
```

### Content View
### Viewer extensions

You can provide custom components that render a particular type of the content based on extensions.
You can provide custom components that render a particular type of the content based on file extensions.

```json
{
Expand All @@ -431,7 +431,7 @@ You can provide custom components that render a particular type of the content b

"features": {
"viewer": {
"content": [
"extensions": [
{
"id": "app.viewer.pdf",
"fileExtension": "pdf",
Expand Down
6 changes: 3 additions & 3 deletions docs/ja/extending/application-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ ACA は、次の拡張ポイントのセットをサポートします:
"viewer": {
"toolbarActions:": [],
"openWith": [],
"content": []
"extensions": []
},
"sidebar": [],
"content-metadata-presets": []
Expand Down Expand Up @@ -376,7 +376,7 @@ ACA の Viewer コンポーネントは、次の拡張ポイントをサポー

"features": {
"viewer": {
"content": [],
"extensions": [],
"toolbarActions:": [],
"openWith": []
}
Expand All @@ -396,7 +396,7 @@ ACA の Viewer コンポーネントは、次の拡張ポイントをサポー

"features": {
"viewer": {
"content": [
"extensions": [
{
"id": "app.viewer.pdf",
"fileExtension": "pdf",
Expand Down
4 changes: 2 additions & 2 deletions docs/tutorials/custom-viewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ You also need to provide in your `app.extension.json` its details:
"$description": "my viewer plugin",
"features": {
"viewer": {
"content": [
"extensions": [
{
"id": "my.custom.viewer",
"fileExtension": ["png", "jpg"],
Expand All @@ -93,7 +93,7 @@ You can also use the `*` wildcard symbol to make your custom viewer implementati
"$description": "my viewer plugin",
"features": {
"viewer": {
"content": [
"extensions": [
{
"id": "my.custom.viewer",
"fileExtension": "*",
Expand Down
2 changes: 1 addition & 1 deletion extension.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@
"items": { "$ref": "#/definitions/contentActionRef" },
"minItems": 1
},
"content": {
"extensions": {
"description": "Viewer content extensions",
"type": "array",
"items": { "$ref": "#/definitions/viewerExtensionRef" },
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-content/assets/app.extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@
}
]
},
"content": [
"extensions": [
{
"id": "app.viewer.pdf",
"disabled": true,
Expand Down
Loading