Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and optimisations #3383

Merged
merged 18 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions e2e/protractor/suites/actions-available/test-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,6 @@ export async function checkToolbarPrimary(item: string, expectedToolbarPrimary:
}
}

export async function checkToolbarMoreActions(item: string, expectedToolbarMore: string[]): Promise<void> {
await dataTable.selectItem(item);
await toolbar.openMoreMenu();

const actualMoreActions = await toolbar.menu.getMenuItems();
for (const action of expectedToolbarMore) {
expect(actualMoreActions.includes(action)).toBe(true, `Expected to contain ${action}`);
}

await toolbar.closeMoreMenu();
}

export async function checkToolbarActions(item: string, expectedToolbarPrimary: string[], expectedToolbarMore: string[]): Promise<void> {
await dataTable.selectItem(item);

Expand Down
2 changes: 1 addition & 1 deletion e2e/protractor/suites/info-drawer/file-preview.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('File preview', () => {
const documentText = 'This is a small demonstration';
await searchInput.searchUntilResult(fileName, 'URL');
await dataTable.selectItem(fileName);
await BrowserActions.click(browsingPage.toolbar.viewDetailsButton);
await BrowserActions.click(infoDrawer.toolbar.viewDetailsButton);
await infoDrawer.previewButton.click();
await viewerPage.checkFileContent(pageNumber, documentText);
});
Expand Down
Loading