Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and optimisations #3383

Merged
merged 18 commits into from
Aug 14, 2023
Merged

Code cleanup and optimisations #3383

merged 18 commits into from
Aug 14, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Aug 12, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove unused css
  • optimize the font family variable
  • remove unused reducer actions
  • fix the old typo in the folder name tool-bar
  • DRY: unify all repetitive markup under single aca-toolbar, reduce the imports

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika requested a review from eromano as a code owner August 12, 2023 23:05
@DenysVuika DenysVuika changed the title Cleanup unused css Cleanup unused css and reducer actions Aug 13, 2023
@DenysVuika DenysVuika changed the title Cleanup unused css and reducer actions Code cleanup and optimisations Aug 13, 2023
@DenysVuika DenysVuika merged commit 27eddf3 into develop Aug 14, 2023
@DenysVuika DenysVuika deleted the css-cleanup branch August 14, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants