Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-4534] nx workspace support for aca #3143

Merged
merged 13 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/publish-libs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ runs:

- name: Build Libraries
shell: bash
run: npm ci && npm run build-libs
run: npm ci && npm run build

- uses: actions/setup-node@v3
name: setup GH registry
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/run-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ runs:
echo "APP_CONFIG_OAUTH2_REDIRECT_SILENT_IFRAME_URI={protocol}//{hostname}{:port}/assets/silent-refresh.html"
} >> .env

npm start > /dev/null &\
npm start content-ce > /dev/null &\

if [ ${{ inputs.test-runner }} == "playwright" ]; then
echo "Running playwright tests with options ${{ inputs.options }}"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
/.tmp
/app/.tmp
/out-tsc
/nxcache

# dependencies
/node_modules
Expand Down
4 changes: 3 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"davidanson.vscode-markdownlint",
"esbenp.prettier-vscode",
"eamodio.gitlens",
"stylelint.vscode-stylelint"
"stylelint.vscode-stylelint",
"nrwl.angular-console",
"dbaeumer.vscode-eslint"
]
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ Changing the ADF code results in the recompilation and hot-reloading of the ACA

## Unit Tests

Use standard Angular CLI commands to test the projects:
Use following command to test the projects:

```sh
ng test <project>
nx test <project>
```

### Code Coverage
Expand All @@ -80,7 +80,7 @@ You can view HTML reports in the `./coverage/<project>` folder.
When working with unit testing and code coverage improvement, you can run unit tests in the "live reload" mode:

```sh
ng test <project> --watch
nx test <project> -- --watch
```

Upon changing unit tests code, you can track the coverage results either in the console output, or by reloading the HTML report in the browser.
Expand Down
Loading