[ACS-4534] nx workspace support for aca #3143
Conversation
AleksanderSklorz
requested review from
TomikaArome,
nikita-web-ua,
jatin2008,
rbahirsheth,
arohilaGL and
MichalKinas
README.md
Outdated
|
|
||
| ```sh | ||
| ng test <project> | ||
| nx affected:test <project> |
There was a problem hiding this comment.
as this section describes running test for a particular project, it should be: nx text <project>
There was a problem hiding this comment.
ah right, corrected
package.json
Outdated
| "build-libs": "ng build aca-shared && ng build adf-office-services-ext && ng build aca-about && ng build aca-viewer && ng build aca-preview && ng build aca-folder-rules && ng build aca-content", | ||
| "test": "ng test", | ||
| "lint": "NODE_OPTIONS=--max_old_space_size=4096 ng lint", | ||
| "build-libs": "nx build aca-shared && nx build adf-office-services-ext && nx build aca-about && nx build aca-viewer && nx build aca-preview && nx build aca-folder-rules && nx build aca-content", |
There was a problem hiding this comment.
can we investigate how to make project dependencies so that this script can be removed? the ADF should have some examples on how one project causes building other dependant ones
There was a problem hiding this comment.
ok I will check thanks
There was a problem hiding this comment.
Looks like it works already in that way by default. After calling:
nx build content-ce (which is build script in package.json)
it builds also all needed libraries. See screenshot:
So I just removed that script
|
Marked is as don't merge for now as discussed with @DenysVuika - just to add some extra scripts. I will unmark it after adding them. |
package.json
Outdated
| "start": "ng serve", | ||
| "start:prod": "npm run validate-app-config && node --max-old-space-size=8192 node_modules/@angular/cli/bin/ng serve --configuration production --open", | ||
| "start": "nx serve content-ce", | ||
| "start:prod": "npm run validate-app-config && node --max-old-space-size=8192 nx run content-ce:serve:production", |
There was a problem hiding this comment.
should be --configuration=production like in the line 16 or line 21
AleksanderSklorz
force-pushed
the
ACS-4534-Nx-Workspace-support-for-ACA
branch
from
ba4fe13 to
06220d2
Compare
|
Removed "do not merge" label as some more scripts have been already added |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-4534
What is the new behaviour?
NX workspace is initialized. We can use nx commands like nx build or nx affected:lint etc. Affected command works based on develop branch. All caches are stored locally in nxcache folder in root of project.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: