-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADF-5532] Create upgrade211-30.md #3112
Changes from 5 commits
681e7a8
3b1b5b9
6150edf
3067e33
f2e080e
28852c8
536ef02
e903a47
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,167 @@ | ||
Upgrade guide ACA V3.0 application compitable with ADF V5.0 | ||
|
||
--- | ||
|
||
Title: Upgrading from ACA v2.11 to v3.0 | ||
|
||
--- | ||
|
||
# Upgrading from ACA v2.11 to v3.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this guide does not describe how to upgrade to the ADF, only contains pieces of the Angular upgrade guide... given that ADF has breaking changes, what should be done in the application to compile? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have checked & verified there is angular upgrade to V14 in ADF v5.0 changelog. So, I have written separate upgrade guide in ADF repo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this guide must help people upgrade everything, it's not the Angular upgrade guide, but the ACA upgrade to ADF having Angular alongside... have you ever seen upgrade guides before? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, you are right. I got your point. I am updating it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rbahirsheth upgrade guide for ADF is totally different thing, in this guide you need to provide instructions on what users should do to make ACA compatible with upgraded ADF and how to fix breaking changes that will appear |
||
|
||
This guide explains how to upgrade your ACA v2.11 app to work with ADF v5.0. | ||
Do not skip this task, if you want your application to be updated to a most recent version of ADF(v5.0). Upgrades of multiple versions of ACA cannot be done in one step only, but should follow the chain of sequential updates. | ||
|
||
**Note:** the steps described below might involve making changes to your code. If you are working with a versioning system then you should commit any changes you are currently working on. If you aren't using versioning then be sure to make a backup copy of your project before going ahead with the upgrade. You can't run ng update to update ANGULAR applications more than one major version at a time. | ||
|
||
Library updates: | ||
|
||
Upgrade ACA app built with ADF v4.11 to a one supporting ADF v5.0, you need to upgrade ANGULAR version v14. You need to upgrade ANGULAR versions from v10 to v14 step by step (single major version at a time). In terms to support ADF v5.0 you have to follow the below commands. There are no such ADF specific changes required in order to compatible with ADF v5.0 (No breaking changes in ADF v5.0) | ||
rbahirsheth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
**Upgrade to v11:** | ||
|
||
To update ANGULAR version from 10.0 to 11.0 by running the below update commands | ||
|
||
```sh | ||
ng update @angular/core@11 @angular/cli@11 –force | ||
npm i | ||
``` | ||
|
||
Below are the some updates when you upgrade to v11.0 | ||
|
||
• ANGULAR now requires TypeScript 4.0. ng update will migrate you automatically. | ||
|
||
• Support for IE9, IE10, and IE mobile has been removed. | ||
|
||
|
||
|
||
**Upgrade to v12:** | ||
|
||
To update ANGULAR version from 11.0 to 12.0 by running the below update commands | ||
|
||
```sh | ||
ng update @angular/core@12 @angular/cli@12 –force | ||
npm i | ||
``` | ||
|
||
Below are the some updates when you upgrade to v12.0 | ||
|
||
• ANGULAR now requires TypeScript 4.2. ng update will update you automatically. | ||
|
||
rbahirsheth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
• IE11 support has been deprecated. | ||
|
||
• You can no longer use ANGULAR with Node.js version 10 or older. | ||
|
||
• Update zone.js to version 0.11.4. ng update will update this dependency automatically. | ||
|
||
• Remove 'emitDecoratorMetadata' TypeScript compiler option. | ||
|
||
• Remove deprecated ViewEngine-based i18n build and extract options. | ||
|
||
• Updates Web Worker consumer usage to use the new syntax supported directly by Webpack 5. | ||
|
||
• `XhrFactory` has been moved from `@angular/common/http` to `@angular/common`. | ||
|
||
|
||
|
||
**Upgrade to v13:** | ||
|
||
To update ANGULAR version from 12.0 to 13.0 by running the below update commands | ||
|
||
```sh | ||
ng update @angular/core@13 @angular/cli@13 –force | ||
npm i | ||
``` | ||
|
||
Below are the some updates when you upgrade to v13.0 | ||
|
||
• ANGULAR now uses TypeScript 4.4. | ||
|
||
• Make sure you are using Node 12.20.0 or later | ||
|
||
• Use [routerLink]="" in templates to [routerLink]="[]" because these links are likely intended to route to the current page with updated fragment/query params. | ||
|
||
• As of ANGULAR version 13, `entryComponents` are no longer necessary. | ||
|
||
• Remove polyfills required only for Internet Explorer which is no longer supported. | ||
|
||
• Remove no longer valid ANGULAR schematic options from `angular.json`. | ||
|
||
|
||
|
||
**Upgrade to v14:** | ||
|
||
To update ANGULAR version from 13.0 to 14.0 by running the below update commands | ||
DenysVuika marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
```sh | ||
ng update @angular/core@14 @angular/cli@14 –force | ||
npm i | ||
``` | ||
|
||
Below are the some updates when you upgrade to v14.0 | ||
|
||
• ANGULAR now uses TypeScript 4.6 | ||
DenysVuika marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
• Make sure you are using Node 14.15.0 or later | ||
|
||
• Update ANGULAR packages 'dependencies' and 'devDependencies' version prefix to '^' instead of '~'. | ||
rbahirsheth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
• Remove 'package.json' files from library projects secondary entrypoints. | ||
|
||
• Update TypeScript compilation target to 'ES2020'. | ||
|
||
|
||
Make sure you have install dev dependency for the below dependecies | ||
|
||
inquirer, winston | ||
rbahirsheth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
```sh | ||
npm install --save-dev inquirer@^8.0.0 | ||
npm install --save-dev winston@^3.8.2 | ||
``` | ||
|
||
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. | ||
|
||
This is no longer the case. Verify if you need this module and configure a polyfill for it. | ||
|
||
If you want to include a polyfill, you need to: | ||
|
||
- add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }' | ||
|
||
- install 'path-browserify' | ||
|
||
If you don't want to include a polyfill, you can use an empty module like this: | ||
|
||
resolve.fallback: { "path": false } | ||
DenysVuika marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
|
||
**Need to update:** | ||
|
||
@ngrx/router-store ^14.0.0 | ||
DenysVuika marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@mat-datetimepicker/core ^9.0.68 | ||
|
||
@mat-datetimepicker/moment ^9.0.68 | ||
|
||
@angular/flex-layout" ^14.0.0-beta.40 | ||
|
||
@angular/cdk 14.2.7 | ||
|
||
@ngx-translate/core ^14.0.02 | ||
|
||
@angular-eslint/builder ^14.0.3 | ||
|
||
@angular-eslint/eslint-plugin ^14.0.3 | ||
|
||
@angular-eslint/eslint-plugin-template ^14.0.3 | ||
|
||
@angular/schematics 14.0.3 | ||
|
||
@angular-eslint/template-parser ^14.0.3 | ||
|
||
moment 2.29.4 | ||
|
||
rxjs 6.6.6 | ||
|
||
zone.js 0.11.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this upgrade guide tells nothing about ADF upgrade, and how to fix breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an ACA upgrade guide. Should i remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what Denys is trying to say is that your guide is missing crucial information about ADF upgrade and its impact on ACA, you should add detailed instructions on how to fix breaking changes after ADF upgrade