[ADF-5532] Create upgrade211-30.md #3112
Conversation
rbahirsheth
changed the title
|
|
||
| --- | ||
|
|
||
| # Upgrading from ACA v2.11 to v3.0 |
There was a problem hiding this comment.
this guide does not describe how to upgrade to the ADF, only contains pieces of the Angular upgrade guide... given that ADF has breaking changes, what should be done in the application to compile?
There was a problem hiding this comment.
I have checked & verified there is angular upgrade to V14 in ADF v5.0 changelog. So, I have written separate upgrade guide in ADF repo.
There was a problem hiding this comment.
this guide must help people upgrade everything, it's not the Angular upgrade guide, but the ACA upgrade to ADF having Angular alongside... have you ever seen upgrade guides before?
There was a problem hiding this comment.
Yes, you are right. I got your point. I am updating it.
There was a problem hiding this comment.
@rbahirsheth upgrade guide for ADF is totally different thing, in this guide you need to provide instructions on what users should do to make ACA compatible with upgraded ADF and how to fix breaking changes that will appear
docs/upgrade-guide/upgrade211-30.md
Outdated
| @@ -0,0 +1,167 @@ | |||
| Upgrade guide ACA V3.0 application compitable with ADF V5.0 | |||
There was a problem hiding this comment.
this upgrade guide tells nothing about ADF upgrade, and how to fix breaking changes
There was a problem hiding this comment.
This is an ACA upgrade guide. Should i remove this line?
There was a problem hiding this comment.
I think what Denys is trying to say is that your guide is missing crucial information about ADF upgrade and its impact on ACA, you should add detailed instructions on how to fix breaking changes after ADF upgrade
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ADF-5532
Upgrade guide was not present for ACA3.0
What is the new behaviour?
Have added upgrade guide for ACA3.0
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: