Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-4441] Destination folder ids are now properly visible on View Rule Screen in Folder Rules #3060

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[ACS-4441] Destination folder ids are now properly visible on View Rule Screen in Folder Rules #3060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"submenus",
"succes",
"superadmin",
"textitem",
"thumbnailed",
"titlecase",
"tooltip",
Expand Down
4 changes: 4 additions & 0 deletions projects/aca-folder-rules/src/lib/rule-details/actions/rule-action.ui-component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@
display: flex;
flex-direction: row;
gap: 20px;

adf-card-view .adf-property-list .adf-property adf-card-view-item-dispatcher adf-card-view-textitem .mat-form-field .mat-form-field-infix {
width: 280px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using an absolute value for this? Is there not a way to have it occupy the rest of the white space to the right? This might risk adding a pointless scroll bar on smaller screen widths

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @TomikaArome I checked by giving values in percentage, but it was not taking the percentage value and mat-form-field-infix value that was setting earlier was 180px, so I changed that and as far as for scroll bar, even earlier scroll was coming in smaller screen widths, so it hasn't changed.

Screenshot from 2023-03-14 18-39-55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll approve for now

}
}
}