[ACS-4441] Destination folder ids are now properly visible on View Rule Screen in Folder Rules #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
suggested changes
Mar 14, 2023
| @@ -3,5 +3,9 @@ | |||
| display: flex; | |||
| flex-direction: row; | |||
| gap: 20px; | |||
|
|
|||
| adf-card-view .adf-property-list .adf-property adf-card-view-item-dispatcher adf-card-view-textitem .mat-form-field .mat-form-field-infix { | |||
| width: 280px; | |||
There was a problem hiding this comment.
Should we be using an absolute value for this? Is there not a way to have it occupy the rest of the white space to the right? This might risk adding a pointless scroll bar on smaller screen widths
There was a problem hiding this comment.
hi @TomikaArome I checked by giving values in percentage, but it was not taking the percentage value and mat-form-field-infix value that was setting earlier was 180px, so I changed that and as far as for scroll bar, even earlier scroll was coming in smaller screen widths, so it hasn't changed.
There was a problem hiding this comment.
Ok I'll approve for now
TomikaArome
approved these changes
Mar 14, 2023
pr-triage
bot
added
PR: partially-approved
and removed
PR: reviewed-changes-requested
labels
AleksanderSklorz
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Folder Rules
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Destination Folder ids are truncated on View Rule screen in Folder Rules
What is the new behaviour?
Destination folder ids are now properly visible on View Rule Screen in Folder Rules
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
before -
After -