fix: Private Endpoint updated NIC resourceID & groupID output (Azure#…

…3606)

## Description

- Fixed the NIC output which was claiming to return the ID while it did
return the entire object
- Updated the group ID to use the `tryGet()` function (and return `null`
if not set)
- Updated UDTs to latest specs

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.private-endpoint](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml/badge.svg?branch=users%2Falsehr%2FpeNetworkInterfacesOutput&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

avm/res/network/private-endpoint/README.md

@@ -1270,11 +1270,11 @@ Tags to be applied on all resources/resource groups in this deployment.
 
 | Output | Type | Description |
 | :-- | :-- | :-- |
-| `customDnsConfig` |  | The custom DNS configurations of the private endpoint. |
+| `customDnsConfig` | array | The custom DNS configurations of the private endpoint. |
 | `groupId` | string | The group Id for the private endpoint Group. |
 | `location` | string | The location the resource was deployed into. |
 | `name` | string | The name of the private endpoint. |
-| `networkInterfaceIds` | array | The IDs of the network interfaces associated with the private endpoint. |
+| `networkInterfaceResourceIds` | array | The resource IDs of the network interfaces associated with the private endpoint. |
 | `resourceGroupName` | string | The resource group the private endpoint was deployed into. |
 | `resourceId` | string | The resource ID of the private endpoint. |
 

avm/res/network/private-endpoint/main.bicep

@@ -9,37 +9,39 @@ param name string
 param subnetResourceId string
 
 @description('Optional. Application security groups in which the private endpoint IP configuration is included.')
-param applicationSecurityGroupResourceIds array?
+param applicationSecurityGroupResourceIds string[]?
 
 @description('Optional. The custom name of the network interface attached to the private endpoint.')
 param customNetworkInterfaceName string?
 
 @description('Optional. A list of IP configurations of the private endpoint. This will be used to map to the First Party Service endpoints.')
-param ipConfigurations ipConfigurationsType
+param ipConfigurations ipConfigurationType[]?
 
 @description('Optional. The private DNS zone group to configure for the private endpoint.')
 param privateDnsZoneGroup privateDnsZoneGroupType?
 
 @description('Optional. Location for all Resources.')
 param location string = resourceGroup().location
 
+import { lockType } from 'br/public:avm/utl/types/avm-common-types:0.2.1'
 @description('Optional. The lock settings of the service.')
-param lock lockType
+param lock lockType?
 
+import { roleAssignmentType } from 'br/public:avm/utl/types/avm-common-types:0.2.1'
 @description('Optional. Array of role assignments to create.')
-param roleAssignments roleAssignmentType
+param roleAssignments roleAssignmentType[]?
 
 @description('Optional. Tags to be applied on all resources/resource groups in this deployment.')
 param tags object?
 
 @description('Optional. Custom DNS configurations.')
-param customDnsConfigs customDnsConfigType
+param customDnsConfigs customDnsConfigType[]?
 
 @description('Optional. A grouping of information about the connection to the remote resource. Used when the network admin does not have access to approve connections to the remote resource.')
-param manualPrivateLinkServiceConnections manualPrivateLinkServiceConnectionsType
+param manualPrivateLinkServiceConnections manualPrivateLinkServiceConnectionType[]?
 
 @description('Optional. A grouping of information about the connection to the remote resource.')
-param privateLinkServiceConnections privateLinkServiceConnectionsType
+param privateLinkServiceConnections privateLinkServiceConnectionType[]?
 
 @description('Optional. Enable/Disable usage telemetry for module.')
 param enableTelemetry bool = true
@@ -178,24 +180,21 @@ output name string = privateEndpoint.name
 output location string = privateEndpoint.location
 
 @description('The custom DNS configurations of the private endpoint.')
-output customDnsConfig customDnsConfigType = privateEndpoint.properties.customDnsConfigs
+output customDnsConfig customDnsConfigType[] = privateEndpoint.properties.customDnsConfigs
 
-@description('The IDs of the network interfaces associated with the private endpoint.')
-output networkInterfaceIds array = privateEndpoint.properties.networkInterfaces
+@description('The resource IDs of the network interfaces associated with the private endpoint.')
+output networkInterfaceResourceIds string[] = map(privateEndpoint.properties.networkInterfaces, nic => nic.id)
 
 @description('The group Id for the private endpoint Group.')
-output groupId string = !empty(privateEndpoint.properties.manualPrivateLinkServiceConnections) && length(privateEndpoint.properties.manualPrivateLinkServiceConnections[0].properties.?groupIds) > 0
-  ? privateEndpoint.properties.manualPrivateLinkServiceConnections[0].properties.?groupIds[0] ?? ''
-  : !empty(privateEndpoint.properties.privateLinkServiceConnections) && length(privateEndpoint.properties.privateLinkServiceConnections[0].properties.?groupIds) > 0
-      ? privateEndpoint.properties.privateLinkServiceConnections[0].properties.?groupIds[0] ?? ''
-      : ''
+output groupId string? = privateEndpoint.properties.?manualPrivateLinkServiceConnections[?0].properties.?groupIds[?0] ?? privateEndpoint.properties.?privateLinkServiceConnections[?0].properties.?groupIds[?0]
 
 // ================ //
 // Definitions      //
 // ================ //
 
 import { privateDnsZoneGroupConfigType } from 'private-dns-zone-group/main.bicep'
 
+@export()
 type privateDnsZoneGroupType = {
   @description('Optional. The name of the Private DNS Zone Group.')
   name: string?
@@ -204,41 +203,8 @@ type privateDnsZoneGroupType = {
   privateDnsZoneGroupConfigs: privateDnsZoneGroupConfigType[]
 }
 
-type roleAssignmentType = {
-  @description('Optional. The name (as GUID) of the role assignment. If not provided, a GUID will be generated.')
-  name: string?
-
-  @description('Required. The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: \'/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11\'.')
-  roleDefinitionIdOrName: string
-
-  @description('Required. The principal ID of the principal (user/group/identity) to assign the role to.')
-  principalId: string
-
-  @description('Optional. The principal type of the assigned principal ID.')
-  principalType: ('ServicePrincipal' | 'Group' | 'User' | 'ForeignGroup' | 'Device')?
-
-  @description('Optional. The description of the role assignment.')
-  description: string?
-
-  @description('Optional. The conditions on the role assignment. This limits the resources it can be assigned to. e.g.: @Resource[Microsoft.Storage/storageAccounts/blobServices/containers:ContainerName] StringEqualsIgnoreCase "foo_storage_container".')
-  condition: string?
-
-  @description('Optional. Version of the condition.')
-  conditionVersion: '2.0'?
-
-  @description('Optional. The Resource Id of the delegated managed identity resource.')
-  delegatedManagedIdentityResourceId: string?
-}[]?
-
-type lockType = {
-  @description('Optional. Specify the name of lock.')
-  name: string?
-
-  @description('Optional. Specify the type of lock.')
-  kind: ('CanNotDelete' | 'ReadOnly' | 'None')?
-}?
-
-type ipConfigurationsType = {
+@export()
+type ipConfigurationType = {
   @description('Required. The name of the resource that is unique within a resource group.')
   name: string
 
@@ -253,9 +219,10 @@ type ipConfigurationsType = {
     @description('Required. A private IP address obtained from the private endpoint\'s subnet.')
     privateIPAddress: string
   }
-}[]?
+}
 
-type manualPrivateLinkServiceConnectionsType = {
+@export()
+type manualPrivateLinkServiceConnectionType = {
   @description('Required. The name of the private link service connection.')
   name: string
 
@@ -270,9 +237,10 @@ type manualPrivateLinkServiceConnectionsType = {
     @description('Optional. A message passed to the owner of the remote resource with this connection request. Restricted to 140 chars.')
     requestMessage: string?
   }
-}[]?
+}
 
-type privateLinkServiceConnectionsType = {
+@export()
+type privateLinkServiceConnectionType = {
   @description('Required. The name of the private link service connection.')
   name: string
 
@@ -287,12 +255,13 @@ type privateLinkServiceConnectionsType = {
     @description('Optional. A message passed to the owner of the remote resource with this connection request. Restricted to 140 chars.')
     requestMessage: string?
   }
-}[]?
+}
 
+@export()
 type customDnsConfigType = {
   @description('Optional. FQDN that resolves to private endpoint IP address.')
   fqdn: string?
 
   @description('Required. A list of private IP addresses of the private endpoint.')
   ipAddresses: string[]
-}[]?
+}