-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Private Endpoint updated NIC resourceID & groupID output #3606
Merged
AlexanderSehr
merged 10 commits into
Azure:main
from
AlexanderSehr:users/alsehr/peNetworkInterfacesOutput
Oct 26, 2024
Merged
fix: Private Endpoint updated NIC resourceID & groupID output #3606
AlexanderSehr
merged 10 commits into
Azure:main
from
AlexanderSehr:users/alsehr/peNetworkInterfacesOutput
Oct 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
Maintainers need to triage still
label
Oct 22, 2024
8 tasks
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
label
Oct 22, 2024
AlexanderSehr
added
Needs: Module Owner 📣
This module needs an owner to develop or maintain it
Type: Bug 🐛
Something isn't working
and removed
Needs: Triage 🔍
Maintainers need to triage still
labels
Oct 22, 2024
eriqua
reviewed
Oct 23, 2024
eriqua
reviewed
Oct 23, 2024
ReneHezser
reviewed
Oct 23, 2024
eriqua
reviewed
Oct 26, 2024
eriqua
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
8 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Nov 29, 2024
## Description - Added KeyVault key & secrets outputs (Note: An output map was technically not possibe) - Moved UDTs to common-types module where possible - Based on #3246 - Depends on #3606 - Depends on microsoft/PSRule#2591 & Release https://github.com/Azure/PSRule.Rules.Azure/milestone/127 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.key-vault.vault](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FGosselin-l_keyvault_key_moreOutputs&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Laurent <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs: Module Owner 📣
This module needs an owner to develop or maintain it
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Bug 🐛
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tryGet()
function (and returnnull
if not set)Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.