Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Private Endpoint updated NIC resourceID & groupID output #3606

Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 22, 2024

Description

  • Fixed the NIC output which was claiming to return the ID while it did return the entire object
  • Updated the group ID to use the tryGet() function (and return null if not set)
  • Updated UDTs to latest specs

Pipeline Reference

Pipeline
avm.res.network.private-endpoint

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 22, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 22, 2024
@AlexanderSehr AlexanderSehr added Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: Bug 🐛 Something isn't working and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 22, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 22, 2024 18:40
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 22, 2024 18:40
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 22, 2024 18:50
@AlexanderSehr AlexanderSehr requested a review from eriqua October 23, 2024 06:06
@eriqua eriqua self-assigned this Oct 24, 2024
@AlexanderSehr AlexanderSehr requested a review from eriqua October 26, 2024 10:58
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit a6743bf into Azure:main Oct 26, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/peNetworkInterfacesOutput branch October 26, 2024 14:11
AlexanderSehr added a commit that referenced this pull request Nov 29, 2024
## Description

- Added KeyVault key & secrets outputs (Note: An output map was
technically not possibe)
- Moved UDTs to common-types module where possible
- Based on #3246
- Depends on #3606
- Depends on microsoft/PSRule#2591 & Release
https://github.com/Azure/PSRule.Rules.Azure/milestone/127

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.key-vault.vault](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FGosselin-l_keyvault_key_moreOutputs&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Laurent <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants