Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle copying/pasting global pages #2241

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Handle copying/pasting global pages #2241

merged 1 commit into from
Feb 28, 2022

Conversation

dbwinger
Copy link
Contributor

What is this pull request for?

Copying and then pasting a global page results in an exception because there is no parent Alchemy::Page.

Notable changes (remove if none)

Handle the possibility of the new parent_page being nil.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

tvdeyen
tvdeyen approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@tvdeyen
Copy link
Member

tvdeyen commented Feb 28, 2022

Spec errors seem unrelated. Restarting

@tvdeyen tvdeyen enabled auto-merge February 28, 2022 19:42
@tvdeyen tvdeyen merged commit 4353d51 into AlchemyCMS:main Feb 28, 2022
dbwinger added a commit to dbwinger/alchemy_cms that referenced this pull request Feb 28, 2022
@dbwinger
Backport AlchemyCMS#2241 to 5.2
7b2de03
@dbwinger dbwinger mentioned this pull request Feb 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwinger @tvdeyen