Merge pull request #2241 from dbwinger/global-page-copy

Handle copying/pasting global pages
AlchemyCMS · Feb 28, 2022 · 4353d51 · 4353d51
2 parents bc4ff7f + ac96c94
commit 4353d51
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/app/models/alchemy/page.rb b/app/models/alchemy/page.rb
@@ -245,8 +245,8 @@ def copy(source, differences = {})
 
       def copy_and_paste(source, new_parent, new_name)
         page = copy(source, {
-          parent_id: new_parent.id,
-          language: new_parent.language,
+          parent: new_parent,
+          language: new_parent&.language,
           name: new_name,
           title: new_name,
         })

diff --git a/spec/models/alchemy/page_spec.rb b/spec/models/alchemy/page_spec.rb
@@ -1163,7 +1163,7 @@ class AnotherUrlPathClass; end
 
       it "should copy the source page with the given name to the new parent" do
         expect(Page).to receive(:copy).with(source, {
-                          parent_id: new_parent.id,
+                          parent: new_parent,
                           language: new_parent.language,
                           name: page_name,
                           title: page_name,
@@ -1184,6 +1184,21 @@ class AnotherUrlPathClass; end
           subject
         end
       end
+
+      context "if the source page has no parent (global page)" do
+        let(:source) { build_stubbed(:alchemy_page, layoutpage: true, parent_id: nil) }
+        let(:new_parent) { nil }
+
+        it "copies the source page with the given name" do
+          expect(Page).to receive(:copy).with(source, {
+                          parent: nil,
+                          language: nil,
+                          name: page_name,
+                          title: page_name,
+                        })
+          subject
+        end
+      end
     end
 
     context "previous and next." do