-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing projects & proposals locales #90
Conversation
@andreslucena it seems we can't deploy this until we deploy #89 since the graphql gem version (1.5.1) was removed from Rubygems. Neither Travis or Heroku can build the environment :/ (I'm waiting on Heroku but it'll possibly error) |
Yup, the deployment failed 😣 |
Maybe we can also add the specs and seeds for this kind of Resources so if we have a regression we can detect it on tests? |
I've updated this PR to also update the dependency on GraphQL so at least we can deploy it. |
@andreslucena the review app is ready! https://decidim-barcelona-pr-90.herokuapp.com |
Note that we noticed that we don't need to merge #89 before merging this, so wan deliver this hotfix while we review all the other changes @andreslucena |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 19 19
Lines 210 210
=======================================
Hits 196 196
Misses 14 14 Continue to review full report at Codecov.
|
Seems to be working OK: https://decidim-barcelona-pr-90.herokuapp.com/processes/3/f/12/results/7 |
🎩 What? Why?
This is a temporary fix until
Decidim
fixes this missing translation.📌 Related Issues