Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing projects & proposals locales #90

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Conversation

oriolgual
Copy link
Contributor

🎩 What? Why?

This is a temporary fix until Decidim fixes this missing translation.

📌 Related Issues

@josepjaume josepjaume temporarily deployed to decidim-barcelona-pr-90 March 27, 2017 15:42 Inactive
@oriolgual
Copy link
Contributor Author

oriolgual commented Mar 27, 2017

@andreslucena it seems we can't deploy this until we deploy #89 since the graphql gem version (1.5.1) was removed from Rubygems. Neither Travis or Heroku can build the environment :/ (I'm waiting on Heroku but it'll possibly error)

@oriolgual
Copy link
Contributor Author

Yup, the deployment failed 😣

@andreslucena
Copy link
Contributor

Maybe we can also add the specs and seeds for this kind of Resources so if we have a regression we can detect it on tests?

@josepjaume josepjaume temporarily deployed to decidim-barcelona-pr-90 March 28, 2017 08:04 Inactive
@oriolgual
Copy link
Contributor Author

I've updated this PR to also update the dependency on GraphQL so at least we can deploy it.

@oriolgual
Copy link
Contributor Author

@oriolgual
Copy link
Contributor Author

@andreslucena the review app is ready! https://decidim-barcelona-pr-90.herokuapp.com

@mrcasals
Copy link
Contributor

Note that we noticed that we don't need to merge #89 before merging this, so wan deliver this hotfix while we review all the other changes @andreslucena

@codecov-io
Copy link

codecov-io commented Mar 28, 2017

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          19       19           
  Lines         210      210           
=======================================
  Hits          196      196           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017268b...f3dcae6. Read the comment docs.

@oriolgual
Copy link
Contributor Author

Seems to be working OK: https://decidim-barcelona-pr-90.herokuapp.com/processes/3/f/12/results/7

@oriolgual oriolgual merged commit ebe4a92 into master Mar 28, 2017
@oriolgual oriolgual deleted the fix/missing_locales branch March 28, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants