Update decidim

[mrcasals]

🎩 What? Why?

Update decidim to the latest version

📌 Related Issues

None

📋 Subtasks

None

[oriolgual]

@andreslucena @arnaumonty please review the test app and approve this if you're OK.

@mrcasals anything special they should review?

[mrcasals]

The changes this updates brings are found here:

AjuntamentdeBarcelona/decidim@c1a80c0...master

There aren't many of them that would affect you directly. I'd say that the only change that affects you is that proposal answers now have a rich text editor instead of a plain one, so you can add links and so.

[codecov-io]

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          19       19           
  Lines         210      210           
=======================================
  Hits          196      196           
  Misses         14       14

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe4a92...4e5b4a9. Read the comment docs.

[andreslucena]

Ok, thanks! We'll review it and tell you guys something tomorrow with @arnaumonty

[andreslucena]

We need to fix this first before merging: https://github.com/AjuntamentdeBarcelona/decidim/issues/1166

[andreslucena]

Another fix that's needed before merging:

https://github.com/AjuntamentdeBarcelona/decidim/issues/875

The test URL:
https://decidim-barcelona-pr-89.herokuapp.com/processes/3/f/9/proposals/60

[mrcasals]

@andreslucena I'm working on fixing these issues, thanks for reporting them! Once they are merged I'll update this PR so that you can check that everything works as expected.

[mrcasals]

@andreslucena I've updated this PR so that all the issues you reported are fixed.

You can see the diff here:

AjuntamentdeBarcelona/decidim@c1a80c0...2d86d48

There are no new changes that affect your installation, as you can see from the commit messages.

So the relevant merged PRs that this update includes are:

• https://github.com/AjuntamentdeBarcelona/decidim/pull/1119 (improved mobile styles for processes)
• https://github.com/AjuntamentdeBarcelona/decidim/pull/1156 (Increase official image sizes)
• https://github.com/AjuntamentdeBarcelona/decidim/pull/1161 + https://github.com/AjuntamentdeBarcelona/decidim/pull/1169 (rich text for proposal answers)
• https://github.com/AjuntamentdeBarcelona/decidim/pull/1171 (fix title in admin section)
• https://github.com/AjuntamentdeBarcelona/decidim/pull/1173 (fix process header layout)

Please check that again using the review app :)

[andreslucena]

@mrcasals can we also add https://github.com/AjuntamentdeBarcelona/decidim/issues/1153 ?

(or maybe just update again)

[andreslucena]

I've reviewed the review app and so I approve this review 👍

[mrcasals]

@andreslucena I've updated decidim to the latest version so we can include https://github.com/AjuntamentdeBarcelona/decidim/issues/1153.

Apart from those listed in the previous message, new merged PRs this update includes are:

• https://github.com/AjuntamentdeBarcelona/decidim/issues/1175 (update Ruby version)
• https://github.com/AjuntamentdeBarcelona/decidim/issues/1176 (List collaborators in admin)
• https://github.com/AjuntamentdeBarcelona/decidim/issues/1177 (add category select prompt in filters)
• https://github.com/AjuntamentdeBarcelona/decidim/issues/1001 (use Typescript in React components)
• https://github.com/AjuntamentdeBarcelona/decidim/issues/1178 (Validate avatar size and dimensions)
• https://github.com/AjuntamentdeBarcelona/decidim/issues/1189 (do not delete banner iamges when updating a process)

@andreslucena you will need to re-review this.

[andreslucena]

The only bug I've found is "Category prompt" that is missing the translation (AjuntamentdeBarcelona/decidim#1177)

[mrcasals]

@andreslucena sorry, my bad. I'm waiting for tests to pass for the translation PR, and once it's merged I'll reupdate this one.

[andreslucena]

@mrcasals ok, when that's done you can merge and deploy to prod

[oriolgual]

@andreslucena updated again! https://decidim-barcelona-pr-89.herokuapp.com

[andreslucena]

Perfect, OK for everything, let's merge and deploy 🥇