Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra validation for checking topic description is between 1 and 100 characters long #2689

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

aindriu-aiven
Copy link
Contributor

@aindriu-aiven aindriu-aiven commented Nov 1, 2024

Add extra validation for checking topic description is between 1 and 100 characters long

Linked issue

Resolves: #2683

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

API does not check this before it tries to commit it to the database causing a generic error to be returned.

What is the new behavior?

A 400 bad request with a helpful response is returned.

Other information

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@aindriu-aiven aindriu-aiven force-pushed the issue-2683-extra-validation branch from f4a9d00 to 56add18 Compare November 1, 2024 13:55
Copy link
Contributor

@muralibasani muralibasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aindriu-aiven aindriu-aiven merged commit 7cf8b8b into main Nov 4, 2024
16 checks passed
@aindriu-aiven aindriu-aiven deleted the issue-2683-extra-validation branch November 4, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coral UI - Exceedingly long topic description fails with generic error
2 participants