Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coral UI - Exceedingly long topic description fails with generic error #2683

Closed
michael-follmann opened this issue Oct 28, 2024 · 4 comments · Fixed by #2689
Closed

Coral UI - Exceedingly long topic description fails with generic error #2683

michael-follmann opened this issue Oct 28, 2024 · 4 comments · Fixed by #2689
Assignees
Labels
bug Something isn't working

Comments

@michael-follmann
Copy link

michael-follmann commented Oct 28, 2024

What happened?

When a user requests a new topic via the React UI and uses a long topic description (for example, 100+ characters), a generic error occurs: Unexpected error

The browser's network console shows a HTTP request with 500 status.

What did you expect to happen?

  • It needs to be more transparent to users why the request is invalid. There already is a form validation for the minimum length of the topic description (String must contain at least 1 character(s)). The maximum length could be validated in a similar way before the request can be submitted.
  • The REST API should respond with HTTP 400 instead of 500.

What else do we need to know?

The Angular UI avioded this issue by having a maxlength in the HTML: <input maxlength="75" ...>

@aindriu-aiven aindriu-aiven added the bug Something isn't working label Oct 29, 2024
@aindriu-aiven
Copy link
Contributor

Thanks @michael-follmann for raising this, it seems like a relatively straight forward one, I'll take a look and see if we can get this addressed.

@aindriu-aiven aindriu-aiven self-assigned this Oct 29, 2024
@aindriu-aiven
Copy link
Contributor

Hi @michael-follmann I was just making some validation updates and testing them, we actually updated the UI already to return validation that 100 characters is the maximum that can be used.
It was fixed in this PR #2547

I currently have also updated some of the validation as well so if the api is used it will also come back with the correct response
{514A4FF9-2CE7-4857-831D-A7CA7E23003B}

@aindriu-aiven
Copy link
Contributor

We have a PR opened to also add this validation to the API now as well.
#2689

@aindriu-aiven
Copy link
Contributor

Merged and issue closed, thanks again for highlighting this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants