Allow super user access to the coral UI #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aindriu-aiven
commented
May 16, 2024
programmiri
reviewed
May 16, 2024
aindriu-aiven
commented
May 16, 2024
| You're currently logged in as superadmin. To experience the new user interface, switch to your user account. | ||
| </p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
this needs a bit of adjusting, its left the landing page in react "smooshed"
There was a problem hiding this comment.
❓ what's where smooshed? :D
There was a problem hiding this comment.
The superadmin old ui dashboard landing page was smooshed.
I think it just needs those css updates we discussed yesterday
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
programmiri
force-pushed
the
issue-2454-allow-access-to-superadmins-to-coral
branch
from
83e1675 to
805e515
Compare
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
muralibasani
deleted the
issue-2454-allow-access-to-superadmins-to-coral
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #2454
What kind of change does this PR introduce?
What is the current behavior?
Super admin could not access coral
What is the new behavior?
Super admin can access coral
Other information
A follow up change is required for allowing to create a request, where the option should only be supplied if the superadmin has the permission.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully