Notify producer and consumer clients when schemas are uploaded on topic #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 12:52
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
| NEW_USER_ADDED, | ||
| RESET_CONSUMER_OFFSET_REQUESTED, | ||
| RESET_CONSUMER_OFFSET_APPROVED, | ||
| RESET_CONSUMER_OFFSET_DENIED | ||
| RESET_CONSUMER_OFFSET_DENIED, |
There was a problem hiding this comment.
Should there be a trailing comma here?
There was a problem hiding this comment.
No, it was by mistake.
| String topic = schemaRequest.getTopicname(); | ||
| String schemaRequestEnvironment = schemaRequest.getEnvironment(); | ||
| Optional<Env> optionalKafkaEnv = | ||
| manageDatabase.getKafkaEnvList(tenantId).stream() |
There was a problem hiding this comment.
Suggested change
| manageDatabase.getKafkaEnvList(tenantId).stream() | |
| Optional<Env> optSchemaEnv = manageDatabase.getEnv(tenantId,schemaRequestEnvironment); | |
| //add null pointer checks. | |
| Optional<Env> optKafkaEnv = manageDatabase.getEnv(tenantId,optSchemaEnv .get().getAssociatedEnv().getId); |
Signed-off-by: muralibasani <[email protected]>
| manageDatabase | ||
| .getHandleDbRequests() | ||
| .getSyncAcls(optionalKafkaEnv.get().getId(), topic, tenantId); | ||
| optionalEnv = |
There was a problem hiding this comment.
Are these OptionalEnv and the OptionalKafkaEnv the same object?
Signed-off-by: muralibasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #1068
What kind of change does this PR introduce?
This change adds a functionality.
Notifies all producers and consumers of a topic for a particular environment, when there are new schemas uploaded onto a topic
Team mail ids are used here
Bug fix
[ X] New feature
Refactor
Docs update
CI update
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
Currently topic subscribers are not notified when there are schema uploads on topic
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
This change notifies topic subscribers when there are new schemas uploaded to topic
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully