Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify producers/consumers on schema changes #1068

Closed
1 task
muralibasani opened this issue Apr 20, 2023 · 13 comments · Fixed by #2060
Closed
1 task

Notify producers/consumers on schema changes #1068

muralibasani opened this issue Apr 20, 2023 · 13 comments · Fixed by #2060
Labels
Backend Backend tasks good first issue Good for newcomers

Comments

@muralibasani
Copy link
Contributor

What is currently missing?

When a new version of schema is uploaded on a topic, producers and consumers should be notified

How could this be improved?

Notifications should be sent when schema changes are done on a topic to all acl owners.

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@muralibasani muralibasani added the Backend Backend tasks label Apr 20, 2023
@muralibasani muralibasani changed the title Notify consumers on schema changes Notify producers/consumers on schema changes Apr 20, 2023
@muralibasani muralibasani added the good first issue Good for newcomers label May 15, 2023
@Sadaf-A
Copy link
Contributor

Sadaf-A commented Aug 8, 2023

Greetings @muralibasani, I would like to work on this could you please link the GitHub file. It would make it a lot easier for me!

@dipeshsingh253
Copy link

Hey @muralibasani , I would like to work on this issue. If it's still available.

@muralibasani
Copy link
Contributor Author

@dipeshsingh253 please go ahead, as you are a new contributor.

@Sadaf-A you might want to review the PR from this.

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Oct 4, 2023

@dipeshsingh253 please go ahead, as you are a new contributor.

@Sadaf-A you might want to review the PR from this.

hey, I hope you are well. did you mean yo say I should review the PR? just wanted to confirm.

@muralibasani
Copy link
Contributor Author

@Sadaf-A let's wait until the PR has been submitted and you can review it. thanks.

@dipeshsingh253
Copy link

Hey @muralibasani Thanks for the opportunity.

Also thanks @Sadaf-A , I will let you know once I'm done with the issue.

Thanks for your patience 😊.

@dipeshsingh253
Copy link

dipeshsingh253 commented Oct 6, 2023

Hey @muralibasani, I was trying to replicate this issue in my local but I am not able to access the clusterapi-webportal in my local.
I am getting this error :

2023-10-06T05:29:50.995+05:30  INFO 13653 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 9343 (http) with context path ''
2023-10-06T05:29:51.032+05:30  INFO 13653 --- [           main] i.a.k.c.KafkaClusterApiApplication       : Started KafkaClusterApiApplication in 4.383 seconds (process running for 5.334)
2023-10-06T05:29:57.341+05:30  INFO 13653 --- [nio-9343-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring DispatcherServlet 'dispatcherServlet'
2023-10-06T05:29:57.342+05:30  INFO 13653 --- [nio-9343-exec-1] o.s.web.servlet.DispatcherServlet        : Initializing Servlet 'dispatcherServlet'
2023-10-06T05:29:57.345+05:30  INFO 13653 --- [nio-9343-exec-1] o.s.web.servlet.DispatcherServlet        : Completed initialization in 2 ms
2023-10-06T05:29:57.382+05:30  WARN 13653 --- [nio-9343-exec-1] i.a.k.c.config.JwtRequestFilter          : JWT Token does not begin with Bearer String
2023-10-06T05:30:40.499+05:30  WARN 13653 --- [nio-9343-exec-2] i.a.k.c.config.JwtRequestFilter          : JWT Token does not begin with Bearer String

I followed this to run Klaw in local : https://www.klaw-project.io/docs/HowTo/installation/run-source

Thanks for your time !!!

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Oct 6, 2023

Hey @muralibasani, I was trying to replicate this issue in my local but I am not able to access the clusterapi-webportal in my local.
I am getting this error :

2023-10-06T05:29:50.995+05:30  INFO 13653 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 9343 (http) with context path ''
2023-10-06T05:29:51.032+05:30  INFO 13653 --- [           main] i.a.k.c.KafkaClusterApiApplication       : Started KafkaClusterApiApplication in 4.383 seconds (process running for 5.334)
2023-10-06T05:29:57.341+05:30  INFO 13653 --- [nio-9343-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring DispatcherServlet 'dispatcherServlet'
2023-10-06T05:29:57.342+05:30  INFO 13653 --- [nio-9343-exec-1] o.s.web.servlet.DispatcherServlet        : Initializing Servlet 'dispatcherServlet'
2023-10-06T05:29:57.345+05:30  INFO 13653 --- [nio-9343-exec-1] o.s.web.servlet.DispatcherServlet        : Completed initialization in 2 ms
2023-10-06T05:29:57.382+05:30  WARN 13653 --- [nio-9343-exec-1] i.a.k.c.config.JwtRequestFilter          : JWT Token does not begin with Bearer String
2023-10-06T05:30:40.499+05:30  WARN 13653 --- [nio-9343-exec-2] i.a.k.c.config.JwtRequestFilter          : JWT Token does not begin with Bearer String

I followed this to run Klaw in local : https://www.klaw-project.io/docs/HowTo/installation/run-source

Thanks for your time !!!

Hello @dipeshsingh253 ,

I kindly request that you format your token as follows:

Bearer ${token}

So, it should be a string that looks like "Bearer <your_token>"

Your attention to this matter is greatly appreciated.

@dipeshsingh253
Copy link

Hello @Sadaf-A , I am using a browser to access the web portal. and also in the docs, there is no mention of how to get the token for the first time.

Can you please elaborate more on this? It will be very helpful.

Thanks ☺️

@muralibasani
Copy link
Contributor Author

muralibasani commented Oct 6, 2023

@Sadaf-A @dipeshsingh253
Klaw cluster api doesn't have a web portal. Only core module has a web portal. And by default it runs at port 9097.
http://localhost:9097

For the token part, in cluster api properties, property klaw.clusterapi.access.base64.secret there is an example token above. You can use the same and copy that token to core module application properties too.

@dipeshsingh253
Copy link

dipeshsingh253 commented Oct 9, 2023

Hi @muralibasani @Sadaf-A ,

I've successfully run and logged into the Klaw UI in my local environment. However, I have faced some difficulties while trying to create a Kafka cluster:

What should be filled in the "rest API server" field in the Kafka cluster creation form?

If there are any how-to guides or documentation available for setting up Klaw locally for development purposes, please share them with me.

I'm curious if there's a Klaw community on Discord or Zulip where I can seek assistance. I couldn't find any links to these platforms and currently, this issue is my sole means of communication.

Thank you!

@muralibasani
Copy link
Contributor Author

muralibasani commented Oct 10, 2023

@dipeshsingh253
https://aiven.io/community/forum/tag/klaw is klaw community

Reg adding cluster, restapiserver is optional field there. Docs : https://www.klaw-project.io/docs/HowTo/clusterconnectivity/kafka-cluster-ssl-protocol

what is your mail id ? I can send a slack invite.

@dipeshsingh253
Copy link

Thanks @muralibasani , and sure here is my email : [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants