Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Exists statement Support (#1760) #1769

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

aindriu-aiven
Copy link
Contributor

  • Remove custom exists queries and use jpql to have spring do queries based on the drivers which handle all details

  • Update to rectify exists statement that had a not clause in it.

  • Use a converter to ensure that the data is converted correctly from the DB to the app and vice versa


About this change - What it does

Merge into a branch release251 which has been branched from tags/v2.5.0 to create a 2.5.1 release with a number of fixes to support mysql.

Resolves: #xxxxx
Why this way

* Remove custom exists queries and use jpql to have spring do queries based on the drivers which handle all details

Signed-off-by: Aindriu Lavelle <[email protected]>

* Run spotless:apply

Signed-off-by: Aindriu Lavelle <[email protected]>

* Update to recitfy exists statement that had a not clause in it.

Signed-off-by: Aindriu Lavelle <[email protected]>

* Use a converter to ensure that the data is converted correctly from the db to the app and vice versa

Signed-off-by: Aindriu Lavelle <[email protected]>

---------

Signed-off-by: Aindriu Lavelle <[email protected]>
@aindriu-aiven aindriu-aiven marked this pull request as ready for review September 14, 2023 13:13
Copy link
Contributor

@muralibasani muralibasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@aindriu-aiven aindriu-aiven merged commit 487f684 into release-251 Sep 14, 2023
@aindriu-aiven aindriu-aiven deleted the fix-mysql-issue branch September 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants