MySQL Exists statement Support #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on the drivers which handle all details Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
| boolean res = schemaRequestRepo.existsRecordsCountForTeamId(teamId, tenantId); | ||
| boolean res = | ||
| schemaRequestRepo.existsByTeamIdAndTenantIdAndRequestStatus( | ||
| teamId, tenantId, RequestStatus.CREATED.value); |
There was a problem hiding this comment.
adding request status parameter intentional ?
There was a problem hiding this comment.
Yes it was hard coded in the native query for the requests it is checking if there is an open request for that team
Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
issue-mysql-support-remove-custom-exists
branch
from
6aea173 to
09dc24b
Compare
| @@ -34,19 +34,11 @@ boolean existsSchemaRequestByEnvironmentAndTenantId( | |||
| boolean existsSchemaRequestByEnvironmentAndTenantIdAndRequestStatus( | |||
There was a problem hiding this comment.
not part of this change, but an unused method, can be deleted.
…he db to the app and vice versa Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
issue-mysql-support-remove-custom-exists
branch
from
a263dcb to
1bea3ba
Compare
|
We found during testing that mysql was only saving datetime down to seconds, where h2 was down to the millisecond. |
aindriu-aiven
added a commit
that referenced
this pull request
Sep 14, 2023
* Remove custom exists queries and use jpql to have spring do queries based on the drivers which handle all details Signed-off-by: Aindriu Lavelle <[email protected]> * Run spotless:apply Signed-off-by: Aindriu Lavelle <[email protected]> * Update to recitfy exists statement that had a not clause in it. Signed-off-by: Aindriu Lavelle <[email protected]> * Use a converter to ensure that the data is converted correctly from the db to the app and vice versa Signed-off-by: Aindriu Lavelle <[email protected]> --------- Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
added a commit
that referenced
this pull request
Sep 14, 2023
* Remove custom exists queries and use jpql to have spring do queries based on the drivers which handle all details * Run spotless:apply * Update to recitfy exists statement that had a not clause in it. * Use a converter to ensure that the data is converted correctly from the db to the app and vice versa --------- Signed-off-by: Aindriu Lavelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom exists queries and use jpql to have spring do queries based on the drivers which handle all details
About this change - What it does
Uses JPQL to handle exists requests and removes the native queries.
Resolves: #xxxxx
Why this way