-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coral) - View environments: Add tables rendering list of environments #1761
Conversation
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Ah, that's tricky 🤔 the query in e.g. KafkaEnvironment ( I... I think this could now be the case where we should think about using a custom hook for this? So it's always the same query (with currentPage and search etc) and we can make use of the cache properly. |
I think a query hook would be great for this use case. I'm going to try it out ^^ |
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
@programmiri I pushed the changes we talked about:
Screen.Recording.2023-09-14.at.12.09.46.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 for the custom hook, solved the problem nicely!
coral/src/app/features/configuration/environments/hooks/getPaginatedEnvironments.tsx
Show resolved
Hide resolved
coral/src/app/features/configuration/environments/components/EnvironmentStatus.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu Anderson <[email protected]>
About this change - What it does
Add table and search field for each environment tab
Screen.Recording.2023-09-13.at.15.28.01.mov
Notes
getPaginatedEnvironmentsForTopicAndAcl
on first load of the page, because we call it inEnvironmentsTabs
to get the amount of env as badges. However, the call inEnvironmentsTabs
hasrefetchOnMount: false
, which will prevent another call until a full page reload. I am not sure how to avoid this.TableLayout
could address this issue (setting a max width to the filters?)Follow up
The
Status
values do not currently have the timestamp value, as this PR #1747 has not been merged yet. I started working on a follow up PR.Resolves: #1707