-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1712 add status information #1747
Conversation
Signed-off-by: Aindriu Lavelle <[email protected]>
…m db every time an env is changed Signed-off-by: Aindriu Lavelle <[email protected]>
…m db every time an env is changed Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
core/src/test/resources/test-application-rdbms-ad-authorization.properties
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/HighAvailabilityUtilsService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Aindriu Lavelle <[email protected]>
…Open/klaw into issue-1712-add-status-information
Signed-off-by: Aindriu Lavelle <[email protected]>
@@ -59,6 +60,7 @@ const mockedEnvironmentsResponse: EnvironmentPaginatedApiResponse = | |||
tenantName: "default", | |||
clusterName: "DEV_CLS", | |||
envStatus: "ONLINE", | |||
envStatusTime: "2023-09-21T11:47:15.664615239", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we don't also want a requesttimestring
property as we have for the[entity]RequestsResponseModel
. We can parse it on the front end, but then we have a potential for divergence if the formatting changes in one of the two spots we are now doing time formatting in :o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding in entStatusRequestedAtTime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I didn't mean to add the time of the request, but having the envStatusTime
formatted in the same way as requesttimestring
🙇 Maybe the following is already what is happening, but the test values express a different thing: https://github.com/Aiven-Open/klaw/pull/1747/files#diff-df59e5cc730be0ccaca740fec7b48fdf327c4430601001cf99da3813e39f32d7R42
The difference between these two: https://github.com/Aiven-Open/klaw/blob/main/openapi.yaml#L7062-L7068
Is that one is the undformatted timestamp (requesttime
) and the other is a formatted string expressing the time in the UTC tz (requesttimestring
)
We are currently doing no parsing of timestamps in the FE, only rendering the already formatted requesttimestring
:
And I thought we might do the same for the envStatusTime
timestamp: same time, but formatted differently.
core/src/main/java/io/aiven/klaw/service/HARestMessagingService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/controller/CacheController.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/controller/CacheController.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/JwtTokenUtilService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/JwtTokenUtilService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/HAMessagingServiceI.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/HAMessagingServiceI.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/service/HAMessagingServiceI.java
Outdated
Show resolved
Hide resolved
…ime the request was made at so the UI is able to determine how long it took. Signed-off-by: Aindriu Lavelle <[email protected]>
…Open/klaw into issue-1712-add-status-information
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks,
About this change - What it does
This PR adds a lastStatusCheckTimestamp
This PR refactors environment caching reducing the number of caches and altering how they communicate so that they do not require a full cache reset on every change to an environment.
There is a second PR that will remove a further cache and also allow the use of Kafka to synchronize multiple instances if desired.
The application.properties has three additional properties
#This allows App2App comunication in a HA setup with multiple Klaw-core instances
# Provide a base 64 encoded string. The same secret should be used in all Instances.
klaw.core.app2app.base64.secret=
A username that can be altered to suit the users needs and improve the security of the app2app user.
klaw.core.app2app.username=KlawApp2App
# Enable High Availability for multi-instance Klaw-core deployment.
# If set to false the additional APIs required for HA will not be exposed reducing resource usage and improving security.
klaw.core.ha.enable=true
Resolves: #1712
Why this way