Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change schema coordinator error logs to warning #920

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: change schema coordinator error logs to warning #920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions karapace/coordinator/schema_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ async def send_req(self, request: Request) -> Response:
try:
resp = await self._client.send(node_id, request, group=ConnectionGroup.COORDINATION)
except Errors.KafkaError as err:
LOG.error(
LOG.warning(
"Error sending %s to node %s [%s] -- marking coordinator dead", request.__class__.__name__, node_id, err
)
self.coordinator_dead()
Expand Down Expand Up @@ -277,7 +277,7 @@ async def _maybe_leave_group(self) -> None:
try:
await self.send_req(request)
except Errors.KafkaError as err:
LOG.error("LeaveGroup request failed: %s", err)
LOG.warning("LeaveGroup request failed: %s", err)
else:
LOG.info("LeaveGroup request succeeded")
self.reset_generation()
Expand Down Expand Up @@ -472,7 +472,7 @@ async def ensure_coordinator_known(self) -> None:
err = Errors.GroupAuthorizationFailedError(self.group_id)
raise err from exc
except Errors.KafkaError as err:
LOG.error("Group Coordinator Request failed: %s", err)
LOG.warning("Group Coordinator Request failed: %s", err)
if err.retriable:
await self._client.force_metadata_update()
await asyncio.sleep(retry_backoff)
Expand Down Expand Up @@ -628,7 +628,7 @@ async def _heartbeat_routine(self) -> None:
# the session timeout has expired without seeing a successful
# heartbeat, so we should probably make sure the coordinator
# is still healthy.
LOG.error("Heartbeat session expired - marking coordinator dead")
LOG.warning("Heartbeat session expired - marking coordinator dead")
self.coordinator_dead()

LOG.debug("Stopping heartbeat task")
Expand All @@ -643,7 +643,7 @@ async def _do_heartbeat(self) -> bool:
try:
resp = await self.send_req(request)
except Errors.KafkaError as err:
LOG.error("Heartbeat send request failed: %s. Will retry.", err)
LOG.warning("Heartbeat send request failed: %s. Will retry.", err)
return False
error_type = Errors.for_code(resp.error_code)
if error_type is Errors.NoError:
Expand Down Expand Up @@ -676,7 +676,7 @@ async def _do_heartbeat(self) -> bool:
raise error_type(self.group_id)
else:
kafka_error = Errors.KafkaError(f"Unexpected exception in heartbeat task: {error_type()!r}")
LOG.error("Heartbeat failed: %r", kafka_error)
LOG.warning("Heartbeat failed: %r", kafka_error)
raise kafka_error
return False

Expand Down
Loading